feat(starknet_integration_tests): sequencer simulator binary #4032
Conversation
|
This change is |
nadin-Starkware
force-pushed
the
spr/main/7c11e54a
branch
from
44ce5cc to
0963023
Compare
nadin-Starkware
force-pushed
the
spr/main/9e5db078
branch
2 times, most recently
from
7705719 to
5aa46ca
Compare
nadin-Starkware
force-pushed
the
spr/main/7c11e54a
branch
from
0963023 to
23ea6c3
Compare
nadin-Starkware
force-pushed
the
spr/main/9e5db078
branch
from
5aa46ca to
c0f6149
Compare
nadin-Starkware
force-pushed
the
spr/main/7c11e54a
branch
from
23ea6c3 to
bb6b652
Compare
nadin-Starkware
force-pushed
the
spr/main/9e5db078
branch
3 times, most recently
from
aedfbc6 to
6d14144
Compare
|
Benchmark movements: |
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion
crates/starknet_integration_tests/src/sequencer_simulator_utils.rs line 54 at r1 (raw file):
pub async fn await_execution(&self, expected_block_number: BlockNumber) { await_execution(&self.monitoring_client, expected_block_number, 0, 0).await;
I prefer a fully qualified name for distinction.
Code quote:
await_execution
nadin-Starkware
force-pushed
the
spr/main/7c11e54a
branch
from
6b1cb44 to
d8f1e98
Compare
nadin-Starkware
force-pushed
the
spr/main/9e5db078
branch
2 times, most recently
from
7210400 to
63f869d
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @lev-starkware)
crates/starknet_integration_tests/src/sequencer_simulator_utils.rs line 54 at r1 (raw file):
Previously, lev-starkware wrote…
I prefer a fully qualified name for distinction.
Done.
|
Benchmark movements: |
There was a problem hiding this comment.
Reviewed 2 of 5 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)
nadin-Starkware
force-pushed
the
spr/main/9e5db078
branch
2 times, most recently
from
dd80f6d to
3e1951d
Compare
nadin-Starkware
force-pushed
the
spr/main/7c11e54a
branch
from
09c1c79 to
ec7b609
Compare
nadin-Starkware
force-pushed
the
spr/main/9e5db078
branch
4 times, most recently
from
f303464 to
3365a38
Compare
nadin-Starkware
force-pushed
the
spr/main/9e5db078
branch
from
3365a38 to
1d68e28
Compare
|
Benchmark movements: |
There was a problem hiding this comment.
Reviewable status: 1 of 5 files reviewed, 1 unresolved discussion (waiting on @lev-starkware)
crates/starknet_integration_tests/src/bin/sequencer_simulator.rs line 23 at r3 (raw file):
default_panic(info); std::process::exit(1); }));
The other stack iirc wrapped this as a function. Add a todo (on you) to use the fn after it is merged.
Code quote:
// TODO(Tsabary): remove the hook definition once we transition to proper usage of task
// spawning.
let default_panic = std::panic::take_hook();
std::panic::set_hook(Box::new(move |info| {
default_panic(info);
std::process::exit(1);
}));
There was a problem hiding this comment.
Reviewable status: 1 of 5 files reviewed, 2 unresolved discussions (waiting on @lev-starkware and @nadin-Starkware)
crates/starknet_integration_tests/src/bin/sequencer_simulator.rs line 24 at r3 (raw file):
std::process::exit(1); })); const SENDER_ACCOUNT: AccountId = 0;
This should be consistent with the setup binary, right? If so, please define them in a unified place.
Code quote:
const SENDER_ACCOUNT: AccountId = 0;
nadin-Starkware
force-pushed
the
spr/main/9e5db078
branch
from
1d68e28 to
bd3d58d
Compare
There was a problem hiding this comment.
Reviewable status: 1 of 5 files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware and @lev-starkware)
crates/starknet_integration_tests/src/bin/sequencer_simulator.rs line 23 at r3 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
The other stack iirc wrapped this as a function. Add a todo (on you) to use the fn after it is merged.
Done.
crates/starknet_integration_tests/src/bin/sequencer_simulator.rs line 24 at r3 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
This should be consistent with the setup binary, right? If so, please define them in a unified place.
Done.
nadin-Starkware
force-pushed
the
spr/main/9e5db078
branch
2 times, most recently
from
70a0c2b to
230eb41
Compare
commit-id:9e5db078
nadin-Starkware
force-pushed
the
spr/main/9e5db078
branch
from
230eb41 to
3fab18f
Compare
There was a problem hiding this comment.
Reviewed 1 of 3 files at r2, 1 of 4 files at r3, 1 of 3 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 1 of 3 files at r2, 1 of 4 files at r3, 1 of 3 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status:
commit-id:9e5db078
Stack: