refactor(starknet_integration_tests): await batcher block more configurable #4323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Feb 20, 2025
noamsp-starkware
requested review from
ShahakShama,
nadin-Starkware and
Itay-Tsabary-Starkware
This was referenced Feb 20, 2025
ShahakShama
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware and @nadin-Starkware)
noamsp-starkware
force-pushed
the
noam.s/refactor_starknet_integration_tests_add_unique_test_ids
branch
from
80c57ae to
e830450
Compare
noamsp-starkware
force-pushed
the
noam.s/refactor_starknet_integration_tests_await_batcher_block_more_configurable
branch
from
6135572 to
2fd05be
Compare
noamsp-starkware
force-pushed
the
noam.s/refactor_starknet_integration_tests_add_unique_test_ids
branch
from
e830450 to
5a90cb3
Compare
noamsp-starkware
force-pushed
the
noam.s/refactor_starknet_integration_tests_await_batcher_block_more_configurable
branch
from
2fd05be to
b74fe07
Compare
This was referenced Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.