-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(starknet_integration_tests): add await sync block marker fn #4324
base: noam.s/refactor_starknet_integration_tests_await_batcher_block_more_configurable
Are you sure you want to change the base?
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
crates/starknet_integration_tests/src/monitoring_utils.rs
line 29 at r1 (raw file):
.get_metric::<u64>(metric_definitions::SYNC_HEADER_MARKER.get_name()) .await .expect("Failed to get sync header marker metric.");
Add all marker types, and for each marker don't consider it if it's zero (if all marker metrics are zero, return zero)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware and @noamsp-starkware)
6135572
to
2fd05be
Compare
9b7cf8e
to
aa16fe2
Compare
2fd05be
to
b74fe07
Compare
aa16fe2
to
e0221f3
Compare
No description provided.