Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starknet_integration_tests): add await sync block marker fn #4324

Open
wants to merge 1 commit into
base: noam.s/refactor_starknet_integration_tests_await_batcher_block_more_configurable
Choose a base branch
from

Conversation

noamsp-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)


crates/starknet_integration_tests/src/monitoring_utils.rs line 29 at r1 (raw file):

        .get_metric::<u64>(metric_definitions::SYNC_HEADER_MARKER.get_name())
        .await
        .expect("Failed to get sync header marker metric.");

Add all marker types, and for each marker don't consider it if it's zero (if all marker metrics are zero, return zero)

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware and @noamsp-starkware)

@noamsp-starkware noamsp-starkware force-pushed the noam.s/refactor_starknet_integration_tests_await_batcher_block_more_configurable branch from 6135572 to 2fd05be Compare February 20, 2025 15:57
@noamsp-starkware noamsp-starkware force-pushed the noam.s/feat_starknet_integration_tests_add_await_sync_block_marker_fn branch from 9b7cf8e to aa16fe2 Compare February 20, 2025 15:57
@noamsp-starkware noamsp-starkware force-pushed the noam.s/refactor_starknet_integration_tests_await_batcher_block_more_configurable branch from 2fd05be to b74fe07 Compare February 20, 2025 16:15
@noamsp-starkware noamsp-starkware force-pushed the noam.s/feat_starknet_integration_tests_add_await_sync_block_marker_fn branch from aa16fe2 to e0221f3 Compare February 20, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants