Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: streamline the starknet api contract class object #524

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Aug 19, 2024

Per @yair-starkware's suggestion.


This change is Reviewable

Copy link
Contributor Author

ArniStarkware commented Aug 19, 2024

@ArniStarkware ArniStarkware marked this pull request as ready for review August 19, 2024 14:43
@ArniStarkware ArniStarkware force-pushed the arni/snapi/contract_class/streamline branch from b38f6d8 to a5fa529 Compare August 20, 2024 11:43
@ArniStarkware ArniStarkware force-pushed the arni/snapi/contract_class/streamline branch from a5fa529 to 7a53f19 Compare August 20, 2024 14:04
Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1 and @yair-starkware)

@ArniStarkware ArniStarkware merged commit 1631d7a into main Aug 21, 2024
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
@ArniStarkware ArniStarkware deleted the arni/snapi/contract_class/streamline branch September 22, 2024 11:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants