-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hironx_ros_bridge] Enable to run CollisionDetector RTC by setting conf (Robot.conf) #535
Merged
k-okada
merged 5 commits into
start-jsk:indigo-devel
from
pazeshun:enable-co-rtc-by-conf
Dec 20, 2019
Merged
[hironx_ros_bridge] Enable to run CollisionDetector RTC by setting conf (Robot.conf) #535
k-okada
merged 5 commits into
start-jsk:indigo-devel
from
pazeshun:enable-co-rtc-by-conf
Dec 20, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis failed.
|
k-okada
reviewed
Nov 22, 2019
k-okada
reviewed
Nov 22, 2019
01c2d23
to
3b5fda6
Compare
3b5fda6
to
0616ce0
Compare
…d with default conf
0616ce0
to
432b9d3
Compare
@k-okada Kindly ping. |
@k-okada kindly ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #537
In our lab's HIRONX, CollisionDetector RTC (co.rtc) can run thanks to fkanehiro/hrpsys-base#1283.
Previously, we just comment in here to run that RTC.
However, this cannot be merged to original repository, so some efforts are required for maintenance.
This PR solves that situation.
If you add the following line to
/opt/jsk/etc/HIRONX/hrprtc/Robot.conf
(inside the robot),hironx.py
brings up CollisionDetector RTC:If that section doesn't exist (common users' case), the behavior of
hironx.py
doesn't change.Also, this PR supports disabling other RTCs from the conf file:
In addition, this PR includes test to check those features (#537).
Memo: Another solution is to load all executable RTCs (CollisionDetector in default HIRONX isn't compiled and executable), but if taking that solution, simulated robot will load CollisionDetector (because it's compiled in local PC).