Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hironx_ros_bridge] Enable to run CollisionDetector RTC by setting conf (Robot.conf) #535

Merged
merged 5 commits into from
Dec 20, 2019

Conversation

pazeshun
Copy link
Contributor

@pazeshun pazeshun commented Nov 22, 2019

Includes #537

In our lab's HIRONX, CollisionDetector RTC (co.rtc) can run thanks to fkanehiro/hrpsys-base#1283.
Previously, we just comment in here to run that RTC.
However, this cannot be merged to original repository, so some efforts are required for maintenance.

This PR solves that situation.
If you add the following line to /opt/jsk/etc/HIRONX/hrprtc/Robot.conf (inside the robot), hironx.py brings up CollisionDetector RTC:

# RTC disable/enable settings which will be loaded via RobotHardware
CollisionDetector.enable: YES

If that section doesn't exist (common users' case), the behavior of hironx.py doesn't change.

Also, this PR supports disabling other RTCs from the conf file:

ServoController.enable: NO

In addition, this PR includes test to check those features (#537).

Memo: Another solution is to load all executable RTCs (CollisionDetector in default HIRONX isn't compiled and executable), but if taking that solution, simulated robot will load CollisionDetector (because it's compiled in local PC).

@pazeshun
Copy link
Contributor Author

Travis failed.
e.g. ROS_DISTRO=indigo ROSWS=wstool BUILDER=catkin USE_DEB=true ROS_REPOSITORY_PATH=http://packages.ros.org/ros/ubuntu:

++ rosdep install -r -n --from-paths src --ignore-src --rosdistro indigo -y
ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
hironx_ros_bridge: Cannot locate rosdep definition for [tf]
hironx_calibration: Cannot locate rosdep definition for [orocos_kdl]
hironx_moveit_config: Cannot locate rosdep definition for [rostest]
rtmros_hironx: Cannot locate rosdep definition for [catkin]
++ catkin_make
-- The C compiler identification is GNU 4.8.4
-- The CXX compiler identification is unknown
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
CMake Error: your CXX compiler: "CMAKE_CXX_COMPILER-NOTFOUND" was not found.   Please set CMAKE_CXX_COMPILER to a valid compiler path or name.
-- Could not find the required component 'hrpsys_ros_bridge'. The following CMake error indicates that you either need to install the package with the same name or change your environment so that it can be found.
CMake Error at /opt/ros/indigo/share/catkin/cmake/catkinConfig.cmake:83 (find_package):
  Could not find a package configuration file provided by "hrpsys_ros_bridge"
  with any of the following names:

    hrpsys_ros_bridgeConfig.cmake
    hrpsys_ros_bridge-config.cmake

  Add the installation prefix of "hrpsys_ros_bridge" to CMAKE_PREFIX_PATH or
  set "hrpsys_ros_bridge_DIR" to a directory containing one of the above
  files.  If "hrpsys_ros_bridge" provides a separate development package or
  SDK, be sure it has been installed.
Call Stack (most recent call first):
  rtmros_hironx/hironx_ros_bridge/CMakeLists.txt:4 (find_package)

@pazeshun pazeshun force-pushed the enable-co-rtc-by-conf branch 2 times, most recently from 01c2d23 to 3b5fda6 Compare November 23, 2019 10:05
@pazeshun pazeshun closed this Nov 23, 2019
@pazeshun pazeshun reopened this Nov 23, 2019
@pazeshun pazeshun closed this Nov 23, 2019
@pazeshun pazeshun reopened this Nov 23, 2019
@pazeshun pazeshun force-pushed the enable-co-rtc-by-conf branch from 3b5fda6 to 0616ce0 Compare November 23, 2019 15:34
@pazeshun pazeshun closed this Nov 23, 2019
@pazeshun pazeshun reopened this Nov 23, 2019
@pazeshun pazeshun closed this Nov 23, 2019
@pazeshun pazeshun reopened this Nov 23, 2019
@pazeshun pazeshun force-pushed the enable-co-rtc-by-conf branch from 0616ce0 to 432b9d3 Compare November 24, 2019 04:31
@pazeshun pazeshun closed this Nov 24, 2019
@pazeshun pazeshun reopened this Nov 24, 2019
@pazeshun pazeshun closed this Nov 24, 2019
@pazeshun pazeshun reopened this Nov 24, 2019
@pazeshun
Copy link
Contributor Author

@k-okada
Travis test of #537 (including tests only) failed, and came to succeed in this PR.
This test checks if CollisionDetector is disabled in normal conf.
This test checks if disabling/enabling RTCs from conf works.
Could you review this PR?

@pazeshun
Copy link
Contributor Author

pazeshun commented Dec 2, 2019

@k-okada Kindly ping.
Is this PR in the correct direction?

@pazeshun
Copy link
Contributor Author

@k-okada kindly ping

@k-okada k-okada merged commit 49d6dd4 into start-jsk:indigo-devel Dec 20, 2019
@pazeshun pazeshun deleted the enable-co-rtc-by-conf branch December 20, 2019 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants