Fix #393: NPE prevents reviewing further findings #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salsolatragus
requested changes
Jun 26, 2018
| @@ -41,10 +41,24 @@ public function getReview(Request $request, Response $response, array $args) | |||
|
|
|||
| $runs = RunsController::getRuns($detector, $experiment, $ex2_review_size); | |||
There was a problem hiding this comment.
Move misuse filtering logic to an accessor on Run::getMisuses($experiment, $max_review_site).
| @@ -41,10 +41,24 @@ public function getReview(Request $request, Response $response, array $args) | |||
|
|
|||
| $runs = RunsController::getRuns($detector, $experiment, $ex2_review_size); | |||
|
|
|||
| $all_misuses = $this->collectAllMisuses($runs); | |||
| $limited_all_misuses = $this->collectAllMisuses($runs); | |||
| if($limited_all_misuses->where('id', $next_reviewable_misuse->id)->isEmpty()){ | ||
| $next_reviewable_misuse = null; | ||
| } | ||
| } |
There was a problem hiding this comment.
Try to reimplement determineNavigationTargets by starting from the current misuse and walking forward/backward to determine the targets.
joschli
force-pushed
the
reviewsite-nav-findings
branch
from
c90e3e8 to
3559d19
Compare
salsolatragus
force-pushed
the
master
branch
3 times, most recently
from
8f1f1a5 to
edd7d88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.