feat(wip): port reference JS implementation to Python#13
Open
0-th wants to merge 22 commits intostoracha:mainfrom
Open
feat(wip): port reference JS implementation to Python#130-th wants to merge 22 commits intostoracha:mainfrom
0-th wants to merge 22 commits intostoracha:mainfrom
Conversation
These functions are necessary for the cooperative scheduler.
The cooperative scheduler (`step` function) uses only `Stack`s for now. `Group`s functionality would be added in further changes resolve storacha#6, resolve storacha#8
Author
|
Running the tests in |
Author
|
59 tests from the reference implementation are passing, all 64 tests have been implemented except 2 type tests that were typescript specific (which I'd assume the type checker - mypy would handle in this Python implementation). 3 of the tests are currently deadlocking, potentially caused by differences in event loop behaviour in Python and JS. These 3 tests are currently commented out, and I'm currently debugging them for a fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cooperative scheduler can run cooperatively run tasks