Make dysnomia releasable on nixpkgs_unstable #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most important change was that now builtins.currentSystem does not exist anymore. This means we need to have one system and import nixpkgs with it and release does not contain all systems anymore. I have no idea about the implications here, I chose the easiest way IMO to get the ball rolling, but I'm happy to go back to the drawing board if needed.
The name attribute is required now.
Importing `nixpkgs` without specifying `system` does not work with flakes as `currentSystem` attribute does not exist. So instead, we need to give nixpkgs and a system. I chose to actually give pkgs directly. Same for python-testing, I chose to give it instead of importing in the test files.
ibizaman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is my ongoing effort to make dysnomia compatible with nixpkgs_unstable.
I can run
nix-build release.nix -A release --arg systems '["i686-linux" "x86_64-linux"]'with the two commented out tests. I can't build for the other systems.