Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dysnomia releasable on nixpkgs_unstable #11

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Commits on Apr 14, 2023

  1. add flake.nix

    The most important change was that now builtins.currentSystem does not
    exist anymore. This means we need to have one system and import
    nixpkgs with it and release does not contain all systems anymore. I
    have no idea about the implications here, I chose the easiest way IMO
    to get the ball rolling, but I'm happy to go back to the drawing board
    if needed.
    ibizaman committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    7866165 View commit details
    Browse the repository at this point in the history
  2. add name to all tests

    The name attribute is required now.
    ibizaman committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    fb92d63 View commit details
    Browse the repository at this point in the history
  3. give pkgs instead of nixpkgs to tests

    Importing `nixpkgs` without specifying `system` does not work with
    flakes as `currentSystem` attribute does not exist. So instead, we
    need to give nixpkgs and a system. I chose to actually give pkgs
    directly. Same for python-testing, I chose to give it instead of
    importing in the test files.
    ibizaman committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    0b288e7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c3f369d View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2023

  1. annotate failing tests

    ibizaman committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    ad10df3 View commit details
    Browse the repository at this point in the history
  2. remove flake.nix

    ibizaman committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    5e67333 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e7e723d View commit details
    Browse the repository at this point in the history