-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make dysnomia releasable on nixpkgs_unstable #11
Draft
ibizaman
wants to merge
7
commits into
svanderburg:master
Choose a base branch
from
ibizaman:flake
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Apr 14, 2023
-
The most important change was that now builtins.currentSystem does not exist anymore. This means we need to have one system and import nixpkgs with it and release does not contain all systems anymore. I have no idea about the implications here, I chose the easiest way IMO to get the ball rolling, but I'm happy to go back to the drawing board if needed.
Configuration menu - View commit details
-
Copy full SHA for 7866165 - Browse repository at this point
Copy the full SHA 7866165View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb92d63 - Browse repository at this point
Copy the full SHA fb92d63View commit details -
give pkgs instead of nixpkgs to tests
Importing `nixpkgs` without specifying `system` does not work with flakes as `currentSystem` attribute does not exist. So instead, we need to give nixpkgs and a system. I chose to actually give pkgs directly. Same for python-testing, I chose to give it instead of importing in the test files.
Configuration menu - View commit details
-
Copy full SHA for 0b288e7 - Browse repository at this point
Copy the full SHA 0b288e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for c3f369d - Browse repository at this point
Copy the full SHA c3f369dView commit details
Commits on Apr 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ad10df3 - Browse repository at this point
Copy the full SHA ad10df3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e67333 - Browse repository at this point
Copy the full SHA 5e67333View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7e723d - Browse repository at this point
Copy the full SHA e7e723dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.