Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group modal dialog states into a record #2139

Merged
merged 3 commits into from
Sep 7, 2024
Merged

Group modal dialog states into a record #2139

merged 3 commits into from
Sep 7, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Sep 5, 2024 •
edited
Loading

A refactoring towards #2138

A new field for the robots dialog will be added to the UIDialogs record next.

Also, move F2 robots dialog rendering code to a new module Swarm.TUI.View.Robot.

@kostmo kostmo force-pushed the refactor/ui-dialogs-state-record branch from 162aee8 to 8e74d73 Compare September 5, 2024 21:40
@kostmo kostmo marked this pull request as ready for review September 5, 2024 21:44
@kostmo kostmo force-pushed the refactor/ui-dialogs-state-record branch from 4466c12 to b2944ba Compare September 5, 2024 22:28
@kostmo kostmo added the Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality. label Sep 6, 2024
@kostmo kostmo force-pushed the refactor/ui-dialogs-state-record branch from b2944ba to f306950 Compare September 6, 2024 02:41
xsebek
xsebek approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@xsebek xsebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kostmo! Every line moved from View.hs counts. 😄

src/swarm-tui/Swarm/TUI/Controller.hs Outdated Show resolved Hide resolved
@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Sep 7, 2024
@mergify mergify bot merged commit 4721f90 into main Sep 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

@xsebek xsebek xsebek approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kostmo @byorgey @xsebek