Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unlock pending btc proposals when doing retry #319

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

mpetrun5
Copy link
Collaborator

Store btc proposals as executed if transaction sent.
Unlock proposals when doing retry to release pending transactions.
Retry can be only called by admin and should only be done when sure that the process that failed
has finished.

Retry mechanism will be soon be revisited and implemented so it is called from a single chain and per depositNonce to make it more granular and flexible.

Description

Related Issue Or Context

Closes: https://www.notion.so/veridise/Unexecuted-proposals-may-be-lost-ddbd27a7e7a34bbd881469e1532d82d5

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

Copy link
Contributor

Go Test coverage is 67.2 %\ ✨ ✨ ✨

Copy link
Contributor

Go Test coverage is 66.7 %\ ✨ ✨ ✨

@mpetrun5 mpetrun5 merged commit 5c67c79 into main Jul 10, 2024
8 checks passed
@mpetrun5 mpetrun5 deleted the fix/unexecuted-proposals-lost branch July 10, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants