Skip to content

Commit

Permalink
Fix a couple of typos from contribution (#3742)
Browse files Browse the repository at this point in the history
Because these touch some core files, we rewrite them from scratch.
  • Loading branch information
Shadowfiend authored Apr 13, 2024
2 parents 44222c4 + 2f2e137 commit 781ae1b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion background/lib/tests/utils.unit.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ describe("Lib Utils", () => {
)

it.each(nonZeroWithLeadingZeros)(
"given number >=1 with leading zeros should should truncate at desired length",
"given number >=1 with leading zeros should truncate at desired length",
({ value, decimalLength, maxDecimalLength, expected }) => {
expect(
truncateDecimalAmount(value, decimalLength, maxDecimalLength),
Expand Down
2 changes: 1 addition & 1 deletion background/services/internal-signer/encryption.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ function requireCryptoGlobal(message?: string) {
* been one before. If no salt is provided, a random salt will be
* generated.
*
* Note that the the symmetric, alone, or the salt *and* the password,
* Note that the symmetric key, alone, or the salt *and* the password,
* together, must be retained to decrypt anything encrypted by the
* returned key. While the salt isn't secret key material, losing it
* could jeopardize access to user data (and therefor, funds).
Expand Down
2 changes: 1 addition & 1 deletion provider-bridge/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
- eg webextension-polyfill is 37KB which is comparable to the size spa web framewoks.
> It's absolutely fine for now bc this way we get to use the same apis everywhere but good thing to have this consideration in the back of our minds
- implement injection restrictions (only valid html files, blacklists?)
- add message validaition mechanism to postMessage/addEventListener used in inpage<>content comm (signing, enveloping, asymmetric encryption etc. Can be as simple as a "parity bit")
- add message validation mechanism to postMessage/addEventListener used in inpage<>content comm (signing, enveloping, asymmetric encryption etc. Can be as simple as a "parity bit")

## window.ethereum debug

Expand Down

0 comments on commit 781ae1b

Please sign in to comment.