Full-Stack Capstone - Booking an Appointment Application. #33

tan12082001 · 2023-12-12T23:06:04Z

Final group capstone - Book an Appointment

Team ( 4 memebers ):

Project Information:

NOTE: Working on two separate Repositories.

Vehicle-Booking-App-Frontend

Vehicle-Booking-App-Frontend-Review-Pull-Request

Instructions for Running the local version:

- bundle install
- secret_base_key generation
* rm credentials.yml.enc
* $ EDITOR="mate --wait" bin/rails credentials:edit

- configure database
* run `rails db:create`
* run `rails db:migrate`

- Rspec
* bundle exec rails db:schema:load RAILS_ENV=test
* rspec spec

Implemented Features:

Created user authentication - user login and signup.
Created a Navigation panel that consists of links to respective pages.
Created a Dashboard that lists all the cars present in the database (Did not add any sample data).
Created Item Details page which can be viewed by clicking on the specific item from the dashboard.
Created a Reserve form that would create reservations for the item (have to click on the Reserve button inside the item details page.
Created Add new car page (to add new cars to the endpoint).
Created Delete Item list - renders names of all the cars present (not deleted items) to be soft deleted(can be accessible from the database).
Created API Documentation.
Applied basic styles for both mobile and desktop versions.

Kanban progress views:

Kanban board initial view:

Kanban board final view:

After External review:

Install Rails App and linters

Setup database

add models

Create Item controller (car controller)

solved failing test for car

Create Controllers tests

update the origins path

Meltrust

Hi,

Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!

To highlight:

Tests are passing✔️
Good readme ✔️

You are really close to finishing the Microverse program!! Keep it up! 👍👍👍

After implementing the requested changes, please submit another review request. ♻️

Check the comments under the review.

Cheers and Happy coding!👏👏👏

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.

Meltrust · 2023-12-13T08:55:23Z

README.md

+  - [Ruby and Rails](https://gorails.com/setup/windows/10)
+  - [Git](https://git-scm.com/book/en/v2/Getting-Started-Installing-Git)
+
+### Setup


Thank you for adding specific instructions about the procedures needed to run setup the app correctly:

Kindly, add those instructions to your readme so all your users are able to setup and run your project smoothly. 👍

Meltrust · 2023-12-13T08:58:01Z

README.md

+### Run tests
+There are no tests to run.


You have included some functional tests:

Kindly, add a "tests" section on your readme with instructions about how to run them correctly. 👍

Meltrust · 2023-12-13T08:58:14Z

README.md

+Open [http://localhost:3000](http://localhost:3000/api/random_greeting) to view it in your browser.
+
+
+### Run tests


You are using Rspec, but the "test" folder still exists, which is used by another test framework. Kindly consider deleting that folder if you are not using it. 👍

Meltrust · 2023-12-13T09:30:16Z

.dockerignore

@@ -0,0 +1,31 @@
+# See https://docs.docker.com/engine/reference/builder/#dockerignore-file for more about ignoring files.


The mobile view has not been implemented yet. I understand this is a work in progress or a future update.

tip: If you feel you've completed 90% of the features, kindly say in your PR description what features will be left out to give a heads-up to the final evaluator and reviewers.

Update the index response body by car ref from soft deletes

…App-Backend into Image-Fix

Image Validation

Create Api documentation

Meltrust

Hi,

Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!

You are really close to finishing the Microverse program!! Keep it up! 👍👍👍

After implementing the requested changes, please submit another review request. ♻️

Check the comments under the review.

Cheers and Happy coding!👏👏👏

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.

Meltrust · 2023-12-14T15:04:01Z

README.md

@@ -0,0 +1,190 @@
+<a name="readme-top"></a>


Please check the frontend review for the comments. 👍

Please check the frontend review for the comments. 👍

Implemented the changes:

Added responsive styles.

TestCases:

Meltrust

Wow, you did it 🎉

Thank you for the changes implemented 💪 🥇 ㊗️

Unless you want to add more features, go ahead to your final presentation ⏩ ⏩ ⏩

You are about to finish the Microverse program. You have come a long way!!!

Good luck in the software industry!! I'll see you there. ✨

Congratulations!!!!!! 🎉

To highlight

Superb job ✔️

Cheers and Happy coding!👏👏👏

Wineshuga and others added 30 commits November 30, 2023 19:53

Install Rails and linters

d407f76

Fix Linters

8553d50

Merge pull request #19 from tan12082001/setup_backend

20a8416

Install Rails App and linters

add database

a64796a

add dependancies

60d0dd2

revert changes , mistake for wrong repo

a1ad0a3

fix rubocop

cd9ad72

Update schema.rb

316af0d

add migrations

5fddb4b

Delete reservation migration file

37bc714

Create join table for user and cars

afcb7fa

Create schema file

fd45069

Make database.yml file DRY

7894059

Remove port from configuration

e57a395

Merge pull request #20 from tan12082001/setup_database

1ea39dd

Setup database

add models

c9c2d2b

Merge pull request #21 from tan12082001/models_users

bdb81cc

add models

Create cars_controller index, show and create actions

a251ccb

Create api routes

2890f9b

Modify models

a763574

Merge pull request #22 from tan12082001/item_controller

3d0b9e5

Create Item controller (car controller)

add authentication for user

6edff41

solve rubocop

ca90c1b

modify file

61a90dc

Create index action for reservations

ebfd222

Add route for reservation index

e23fe60

Update my reservation index to find user with id

2c0b83e

Modify my reservation index route to use user id

5ce2227

Add authentication to controller

5f98a8e

add index

f948e2b

hetrox8 and others added 3 commits December 12, 2023 20:05

Merge pull request #32 from tan12082001/test-models-fix

7a56d9f

solved failing test for car

all test pass

8713a3b

Merge pull request #31 from tan12082001/controllers_tests

1596f8b

Create Controllers tests

tan12082001 mentioned this pull request Dec 12, 2023

Full-Stack Capstone - Book an appointment application. tan12082001/Vehicle-Booking-App-Frontend#14

Merged

tan12082001 and others added 2 commits December 13, 2023 14:03

update the origins path

50ae9db

Merge pull request #34 from tan12082001/update-cors-config

843d310

update the origins path

Meltrust suggested changes Dec 13, 2023

View reviewed changes

hetrox8 and others added 20 commits December 13, 2023 13:49

add gems for api documentation

3f9bdd1

try fix api

4bf1f3a

Update the index response body by car ref from soft deletes

42a1c27

solve agin

bc35fd5

swagger fixed

1ec8f7c

Image Validation

e818b9d

Merge pull request #35 from tan12082001/reservations-response-bug-fix

bdc97fc

Update the index response body by car ref from soft deletes

Image Validation

915d2f1

Image Validation

a4479df

Merge branch 'dev' of https://github.com/tan12082001/Vehicle-Booking-…

e8a0bb2

…App-Backend into Image-Fix

Merge pull request #36 from tan12082001/Image-Fix

2e2c572

Image Validation

Modify documentation

f8e498a

Edit README

7fbbe5e

Delete test folder as suggested

b789686

Add schemas and delete car path

b5491a8

Merge branch 'dev' into api-documentation

1f14db9

Fix rubocop issues

a1d8493

Add api docs details to readme file

ac73cd2

fix descriptions in api-doc

15547c8

Merge pull request #37 from tan12082001/api-documentation

2b5a6a0

Create Api documentation

Meltrust suggested changes Dec 14, 2023

View reviewed changes

Meltrust approved these changes Dec 14, 2023

View reviewed changes

tan12082001 merged commit bd4af51 into main Dec 14, 2023
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Full-Stack Capstone - Booking an Appointment Application. #33

Full-Stack Capstone - Booking an Appointment Application. #33

tan12082001 commented Dec 12, 2023 •

edited

Loading

Meltrust left a comment

Meltrust Dec 13, 2023

Meltrust Dec 13, 2023

Meltrust Dec 13, 2023

Meltrust Dec 13, 2023

Meltrust left a comment

Meltrust Dec 14, 2023

tan12082001 Dec 14, 2023 •

edited

Loading

Meltrust left a comment

		Open [http://localhost:3000](http://localhost:3000/api/random_greeting) to view it in your browser.


		### Run tests

		@@ -0,0 +1,31 @@
		# See https://docs.docker.com/engine/reference/builder/#dockerignore-file for more about ignoring files.

Full-Stack Capstone - Booking an Appointment Application. #33

Full-Stack Capstone - Booking an Appointment Application. #33

Conversation

tan12082001 commented Dec 12, 2023 • edited Loading

Final group capstone - Book an Appointment

Team ( 4 memebers ):

Project Information:

Vehicle-Booking-App-Frontend

Vehicle-Booking-App-Frontend-Review-Pull-Request

Instructions for Running the local version:

Implemented Features:

Kanban progress views:

Kanban board initial view:

Kanban board final view:

After External review:

Meltrust left a comment

Choose a reason for hiding this comment

To highlight:

You are really close to finishing the Microverse program!! Keep it up! 👍👍👍

After implementing the requested changes, please submit another review request. ♻️

Meltrust Dec 13, 2023

Choose a reason for hiding this comment

Meltrust Dec 13, 2023

Choose a reason for hiding this comment

Meltrust Dec 13, 2023

Choose a reason for hiding this comment

Meltrust Dec 13, 2023

Choose a reason for hiding this comment

Meltrust left a comment

Choose a reason for hiding this comment

You are really close to finishing the Microverse program!! Keep it up! 👍👍👍

After implementing the requested changes, please submit another review request. ♻️

Meltrust Dec 14, 2023

Choose a reason for hiding this comment

tan12082001 Dec 14, 2023 • edited Loading

Choose a reason for hiding this comment

Meltrust left a comment

Choose a reason for hiding this comment

Wow, you did it 🎉

Thank you for the changes implemented 💪 🥇 ㊗️

Unless you want to add more features, go ahead to your final presentation ⏩ ⏩ ⏩

You are about to finish the Microverse program. You have come a long way!!!

Good luck in the software industry!! I'll see you there. ✨

Congratulations!!!!!! 🎉

To highlight

tan12082001 commented Dec 12, 2023 •

edited

Loading

tan12082001 Dec 14, 2023 •

edited

Loading