Full-Stack Capstone - Book an appointment application. #14

tan12082001 · 2023-12-12T23:57:24Z

Final group capstone - Book an Appointment

Team ( 4 memebers ):

Project Information:

NOTE: Working on two separate Repositories.

Vehicle-Booking-App-Backend

Vehicle-Booking-App-Frontend-Review-Pull-Request

Instructions for Running the local version:

- npm install
- npm start

note: run `rails s` for API  endpoints.

Implemented Features:

Created user authentication - user login and signup.
Created a Navigation panel that consists of links to respective pages.
Created a Dashboard that lists all the cars present in the database (Did not add any sample data).
Created Item Details page which can be viewed by clicking on the specific item from the dashboard.
Created a Reserve form that would create reservations for the item (have to click on the Reserve button inside the item details page.
Created Add new car page (to add new cars to the endpoint).
Created Delete Item list - renders names of all the cars present (not deleted items) to be soft deleted(can be accessible from the database).
Created API Documentation.
Applied basic styles for both mobile and desktop versions.

Kanban progress views:

Kanban board initial view:

Kanban board final view:

create empty files for folder structure

Initial project setup

Routes and Components

(not tested as api endpoint is not accessable)

Login signup Form components

feature and update store with reducer.

create a form component for reservat car

…App-Frontend into Pages

(works - able to login to an existing user, able to create a new user)

Pages

Meltrust

Hi,

Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!

To highlight:

Tests are passing✔️

You are really close to finishing the Microverse program!! Keep it up! 👍👍👍

After implementing the requested changes, please submit another review request. ♻️

Check the comments under the review.

Cheers and Happy coding!👏👏👏

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.

src/components/DeleteCars/DeleteList.js

src/layout/UsersDashboard/sideNav/navConfig.js

src/layout/UsersDashboard/UsersDashboardLayout.js

src/models/car.model.js

src/pages/LandingPage/Home/Home.js

src/components/DeleteCars/DeleteList.js

Meltrust · 2023-12-13T09:29:21Z

src/styles/App.css

@@ -0,0 +1,144 @@
+* {


The mobile view has not been implemented yet. I understand this is a work in progress or a future update.

tip: If you feel you've completed 90% of the features, kindly say in your PR description what features will be left out to give a heads-up to the final evaluator and reviewers.

tip 2: If you declare in your description that the mobile view will be left out, I will still approve the project, however, I don't recommend leaving it undone for final evaluation because this is a huge feature. The final evaluator will make the final decision.

tip 3: If you decide to implement it, you could do so in a simple, but functional way in order to improve your chances (MVP).

tip 4: When dealing with mobile views, the flex column is our best, simple, fast friend. Just make sure the content fits the screen and the navbar does not get in the way

Meltrust · 2023-12-13T09:44:54Z

src/App.js

+import Router from './routes/routes';
+import { fetchCarReservations, fetchCars } from './redux/thunk';
+
+function App() {


The images of the cars come up as null:

Kindly, make it so the images of the cars show up. 👍

src/pages/Auth/SignIn/SignIn.js

src/components/MyReservations/MyReservationsList.js

Bugs fix/styles

Dashboard Styling

…App-Frontend into state-bug-fix

State bug fix

Style

Meltrust

Hi,

Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!

You are really close to finishing the Microverse program!! Keep it up! 👍👍👍

After implementing the requested changes, please submit another review request. ♻️

Check the comments under the review.

Cheers and Happy coding!👏👏👏

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.

Meltrust · 2023-12-14T14:39:55Z

README.md

@@ -0,0 +1,308 @@
+<div align="center">


One of the frontend tests is no longer working, kindly fix it so it passes. 👍

src/App.js

Meltrust · 2023-12-14T14:59:48Z

src/styles/App.css

@@ -0,0 +1,266 @@
+* {


OPTIONAL: The mobile view home page is very questionable:

Also, the maximum width seems to be 375px which is tiny for almost every phone. I suggest you raise that number so more phones can enjoy your work.

this is optional because in the last review you said you've completed 90% of the features.

Meltrust · 2023-12-14T15:03:19Z

src/App.js

+import Router from './routes/routes';
+
+const App = () => (
+  <>


OPTIONAL: If I reload the page, all the information disappears from all sections.

The only way to display the information again is to logout and login again. I suggest you look into this issue.

Fix bugs review 2

Meltrust

Wow, you did it 🎉

Thank you for the changes implemented 💪 🥇 ㊗️

Unless you want to add more features, go ahead to your final presentation ⏩ ⏩ ⏩

You are about to finish the Microverse program. You have come a long way!!!

Good luck in the software industry!! I'll see you there. ✨

Congratulations!!!!!! 🎉

To highlight

Superb job ✔️

Cheers and Happy coding!👏👏👏

tan12082001 and others added 30 commits December 1, 2023 19:35

Initital react app install

516cb44

Install babel, stylelint and eslint linters

e078ccd

Installed toolkit,axios,router-dom,logger.

bd85ea0

Fix linter errors, remove unused files,

55aff45

create empty files for folder structure

Merge pull request #1 from tan12082001/initial-project-setup

ed4b66d

Initial project setup

Routes and Components

05264e7

Merge pull request #2 from tan12082001/Routing

424e575

Routes and Components

Fix linter errors and add prop validations

bd900cd

Update the sign up form with components

e6b9908

configure local store

c00b452

create async methods for signup, login, logout and

c1343e4

(not tested as api endpoint is not accessable)

Update the signIn form with components

1ca662f

Use the HideableTextFormField component

0eb5b60

Merge pull request #3 from tan12082001/login-signup-components

55000e0

Login signup Form components

Update the reserve cars routes and add img

72ca957

Eslint linters fix

ad1ba85

create Slice method for the reservation

fccd2d4

feature and update store with reducer.

Create reserver car model,

26b9778

create a form component for reservat car

Update the form components with date picker method

67da189

Install datepicker, format and add styles.

11a52bd

Navigation and Pages

025c50a

Merge branch 'dev' of https://github.com/tan12082001/Vehicle-Booking-…

c1210e3

…App-Frontend into Pages

sidenav

ed2ed6c

Update async functions

bb7b534

Check api endpoints for user login and signup.

af47e6d

(works - able to login to an existing user, able to create a new user)

Merge pull request #5 from tan12082001/Pages

df62dc1

Pages

Display Item Page and Each Item upon click

5e88ee4

remove unused images.

e19344c

Add async thunk method to fetch my reservations

ee2971e

Update the My reservations component and styles

bb89b02

tan12082001 added 2 commits December 13, 2023 04:05

Update the state, add styles.

42cd755

snapshots update after bug fix updates

ff03823

tan12082001 mentioned this pull request Dec 12, 2023

Full-Stack Capstone - Booking an Appointment Application. tan12082001/Vehicle-Booking-App-Backend#33

Merged

tan12082001 added 2 commits December 13, 2023 09:52

Fix form component id,classname warnings

a85be6d

fix car name display bug

a3d4143

Meltrust suggested changes Dec 13, 2023

View reviewed changes

Simpleshaikh1 and others added 4 commits December 13, 2023 11:14

Merge pull request #15 from tan12082001/bugs-fix/styles

8956b8e

Bugs fix/styles

Dashboard Styling

12045d0

fix state usage and dispatch method bugs

ca57190

Eslint linter fix

58b80b3

tan12082001 mentioned this pull request Dec 13, 2023

State bug fix #17

Merged

tan12082001 and others added 11 commits December 14, 2023 09:39

add breakpoint styles for the landing page

961bc02

Add breakpoint styles for few components

bfa5da3

update the styles for a component

2aa0bfa

Merge pull request #16 from tan12082001/Style

0be3137

Dashboard Styling

Update tests after rendering updates.

e2d22bc

Merge branch 'dev' of https://github.com/tan12082001/Vehicle-Booking-…

8e5f94e

…App-Frontend into state-bug-fix

Update the Datepicker to show value

24ef800

Merge pull request #17 from tan12082001/state-bug-fix

2b8fc77

State bug fix

IMage

d4d1341

updates

56006b1

Merge pull request #18 from tan12082001/Style

7120a84

Style

Meltrust suggested changes Dec 14, 2023

View reviewed changes

tan12082001 added 2 commits December 14, 2023 21:24

Update test cases

08ed0df

Update the failing test suites, update styles.

8c70b62

tan12082001 mentioned this pull request Dec 14, 2023

Fix bugs review 2 #19

Merged

tan12082001 added 2 commits December 15, 2023 00:53

remove back colors

3a9f798

Merge pull request #19 from tan12082001/fix-bugs-review-2

18e5aa3

Fix bugs review 2

Meltrust approved these changes Dec 14, 2023

View reviewed changes

tan12082001 merged commit 228f017 into main Dec 14, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Full-Stack Capstone - Book an appointment application. #14

Full-Stack Capstone - Book an appointment application. #14

tan12082001 commented Dec 12, 2023 •

edited

Loading

Meltrust left a comment

Meltrust Dec 13, 2023

Meltrust Dec 13, 2023

Meltrust left a comment

Meltrust Dec 14, 2023

Meltrust Dec 14, 2023

Meltrust Dec 14, 2023

Meltrust left a comment

Full-Stack Capstone - Book an appointment application. #14

Full-Stack Capstone - Book an appointment application. #14

Conversation

tan12082001 commented Dec 12, 2023 • edited Loading

Final group capstone - Book an Appointment

Team ( 4 memebers ):

Project Information:

Vehicle-Booking-App-Backend

Vehicle-Booking-App-Frontend-Review-Pull-Request

Instructions for Running the local version:

Implemented Features:

Kanban progress views:

Kanban board initial view:

Kanban board final view:

Meltrust left a comment

Choose a reason for hiding this comment

To highlight:

You are really close to finishing the Microverse program!! Keep it up! 👍👍👍

After implementing the requested changes, please submit another review request. ♻️

Meltrust Dec 13, 2023

Choose a reason for hiding this comment

Meltrust Dec 13, 2023

Choose a reason for hiding this comment

Meltrust left a comment

Choose a reason for hiding this comment

You are really close to finishing the Microverse program!! Keep it up! 👍👍👍

After implementing the requested changes, please submit another review request. ♻️

Meltrust Dec 14, 2023

Choose a reason for hiding this comment

Meltrust Dec 14, 2023

Choose a reason for hiding this comment

Meltrust Dec 14, 2023

Choose a reason for hiding this comment

Meltrust left a comment

Choose a reason for hiding this comment

Wow, you did it 🎉

Thank you for the changes implemented 💪 🥇 ㊗️

Unless you want to add more features, go ahead to your final presentation ⏩ ⏩ ⏩

You are about to finish the Microverse program. You have come a long way!!!

Good luck in the software industry!! I'll see you there. ✨

Congratulations!!!!!! 🎉

To highlight

tan12082001 commented Dec 12, 2023 •

edited

Loading