-
Notifications
You must be signed in to change notification settings - Fork 16
Fix wrong json file name #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
gui was using paramCGRA.json.
| } | ||
|
|
||
| ifstream paramCGRA("./param.json"); | ||
| ifstream paramCGRA("./paramCGRA.json"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, can we just align with param.json?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the paramCGRA.json used in CGRA-Mapper may be a little confused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richardissuperman can we try to use param.json inside the gui?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I have done this in UI side as mentioned in #52 but still mapping issue so didn't check in yet, Qing can try from your side also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuqisun sorry im a bit confused, what is the ultimate goal here ? param.json or paramCGRA.json ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuqisun @richardissuperman plz align with param.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think we can do this in GUI side directly in case causing issue in MM's mapper script. WDYT @richardissuperman ?
gui was using paramCGRA.json.