Skip to content

Fix wrong json file name #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix wrong json file name #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/CGRA.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ CGRA::CGRA(int t_rows, int t_columns, bool t_diagonalVectorization,
}
}

ifstream paramCGRA("./param.json");
ifstream paramCGRA("./paramCGRA.json");
Copy link
Owner

@tancheng tancheng Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, can we just align with param.json?

Copy link
Collaborator

@MeowMJ MeowMJ Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so.

Copy link
Collaborator

@MeowMJ MeowMJ Aug 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the paramCGRA.json used in CGRA-Mapper may be a little confused.

Copy link
Owner

@tancheng tancheng Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardissuperman can we try to use param.json inside the gui?

Copy link
Collaborator

@yuqisun yuqisun Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I have done this in UI side as mentioned in #52 but still mapping issue so didn't check in yet, Qing can try from your side also.

Copy link
Author

@richardissuperman richardissuperman Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuqisun sorry im a bit confused, what is the ultimate goal here ? param.json or paramCGRA.json ？

Copy link
Owner

@tancheng tancheng Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuqisun @richardissuperman plz align with param.json

Copy link
Collaborator

@yuqisun yuqisun Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we can do this in GUI side directly in case causing issue in MM's mapper script. WDYT @richardissuperman ?

if (!paramCGRA.good()) {
cout<<"Parameterizable CGRA design/mapping requires paramCGRA.json"<<endl;
return;
Expand Down