Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save data to the correct directory when pruning with path specified #3608

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

therazix
Copy link
Collaborator

@therazix therazix commented Mar 18, 2025

When pruning a repository with a specified path, the discover step now saves the data to the correct temporary directory and respects the structure of the original repository. This ensures that the test attributes have correct paths.

Fixes: #3589

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@therazix therazix added step | discover Stuff related to the discover step priority | must high priority, must be included in the next release bug Something isn't working labels Mar 18, 2025
@therazix therazix added this to the 1.45 milestone Mar 18, 2025
@therazix therazix mentioned this pull request Mar 18, 2025
1 task
@therazix therazix added the ci | full test Pull request is ready for the full test execution label Mar 18, 2025
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@therazix maybe a release note about this bug fix would be nice

@therazix
Copy link
Collaborator Author

LGTM

@therazix maybe a release note about this bug fix would be nice

Added in 6ce737b.

@happz happz force-pushed the fvagner-prune-path branch from 6ce737b to 92eb89a Compare March 19, 2025 07:58
@happz happz merged commit 7adf386 into main Mar 19, 2025
22 checks passed
@happz happz deleted the fvagner-prune-path branch March 19, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci | full test Pull request is ready for the full test execution priority | must high priority, must be included in the next release step | discover Stuff related to the discover step
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discover does not update test attributes after pruning with path specified
3 participants