Ready: Grant notes while onboarding to DSE and taking 102 courses.#45
Ready: Grant notes while onboarding to DSE and taking 102 courses.#45MasonEgger merged 7 commits intomainfrom
Conversation
| TranslationActivityInput goodbyeInput = new TranslationActivityInput("goodbye", languageCode); | ||
| // TODO: Add a log statement here at the debug level stating that the Activity is going | ||
| // to be invoked. Be sure to include the word being translated and the language code. | ||
| TranslationActivityInput goodbyeInput = new TranslationActivityInput("goodbye", languageCode); |
There was a problem hiding this comment.
definitely no biggie, but I just moved the instruction comment below where goodbyeInput was defined because if the learner puts it just below the note, it isn't defined yet
There was a problem hiding this comment.
We want the log to happen prior to the activity being invoked, that way we could look at the logs and know that if we haven't seen logs after that an activity is retrying. They should be logging the variables and not using the result from goodbyInput.
exercises/testing-code/README.md
Outdated
| 9. Save your changes | ||
| 10. Add the following code at the bottom of the `TranslateActivityInput` class. | ||
| 10. Add the following code at the bottom of the `TranslateActivityInput` class, | ||
| and add this import at the top of the file: `import java.util.Objects;`. |
There was a problem hiding this comment.
The user could certainly figure this out, but I think they need to add this import for the code we're adding below to work
There was a problem hiding this comment.
This is not necessary. It's java.lang.Object. All tests in the solution directory run as expected.
| - The `helloMessage` field in the result is `Bonjour, Pierre` | ||
| - The `goodbyeMessage` field in the result is `Au revoir, Pierre` | ||
| - The `helloMessage` field in the output is `Bonjour, Pierre` | ||
| - The `goodbyeMessage` field in the output is `Au revoir, Pierre` |
There was a problem hiding this comment.
the variable is named output
| that your microservice is running as stated above. Then run the test. | ||
|
|
||
| 1. Run the `mvn test` command to execute the provided test | ||
| 1. `cd` into `exercises/testing-code/practice/` |
There was a problem hiding this comment.
I had to cd in. not sure if we have already written that somewhere or if we assume the user can figure that out 👍
| package translationworkflow; | ||
|
|
||
| import java.net.HttpURLConnection; | ||
| import java.net.ProtocolException; |
There was a problem hiding this comment.
I don't think this was being used
| import java.io.IOException; | ||
| import io.temporal.activity.Activity; | ||
| import io.temporal.failure.ApplicationFailure; | ||
| import java.net.HttpURLConnection; |
There was a problem hiding this comment.
I don't think this was being used
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; |
There was a problem hiding this comment.
Step B2 in the readme is to add these imports, so I think we want to remove them from the code 👍
GSmithApps
changed the title
2 participants
What was changed
I just made some changes and fixed typos etc as I was taking the 102 courses.
How was this tested
I ran the code as I took the courses, and I left my fixes as I fixed or modified things.
Misc Note
I have a similar PR for the other languages in 102 code repo and content repo, so ~8 of these (4 * 2).