-
Notifications
You must be signed in to change notification settings - Fork 18
Ready: Grant notes while onboarding to DSE and taking 102 courses. #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
99cfec0
3250c59
d0734c1
6b7e170
76a74c1
5dae09e
ef06c9a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,6 @@ | ||
| package translationworkflow; | ||
|
|
||
| import java.net.HttpURLConnection; | ||
| import java.net.ProtocolException; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this was being used |
||
| import java.net.URI; | ||
| import java.net.URL; | ||
| import java.net.URLEncoder; | ||
|
|
@@ -10,10 +9,7 @@ | |
| import java.io.IOException; | ||
| import io.temporal.activity.Activity; | ||
| import io.temporal.failure.ApplicationFailure; | ||
| import java.net.HttpURLConnection; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this was being used |
||
|
|
||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
Comment on lines
-15
to
-16
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Step B2 in the readme is to add these imports, so I think we want to remove them from the code 👍 |
||
| import translationworkflow.model.TranslationActivityInput; | ||
| import translationworkflow.model.TranslationActivityOutput; | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,9 +49,10 @@ translates the term "Hello" to German. Take a moment to study the | |
| test, which you'll find in the `TranslationActivitiesTest.java` file in the | ||
| `src/test/java/translationworkflow` directory. Since the test runs the | ||
| Activity, which in turn calls the microservice to do the translation, ensure | ||
| that your microservice is running as state above. Then run the test. | ||
| that your microservice is running as stated above. Then run the test. | ||
|
|
||
| 1. Run the `mvn test` command to execute the provided test | ||
| 1. `cd` into `exercises/testing-code/practice/` | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I had to cd in. not sure if we have already written that somewhere or if we assume the user can figure that out 👍 |
||
| 2. Run the `mvn test` command to execute the provided test | ||
|
|
||
| ## Part B: Write and Run Another Test for the Activity | ||
|
|
||
|
|
@@ -107,8 +108,8 @@ following steps: | |
| 1. Edit the `TranslationWorkflowTest.java` file in the | ||
| `src/test/java/translationworkflow` directory | ||
| 2. Add assertions for the following conditions to the `testSuccessfulTranslation` test | ||
| - The `helloMessage` field in the result is `Bonjour, Pierre` | ||
| - The `goodbyeMessage` field in the result is `Au revoir, Pierre` | ||
| - The `helloMessage` field in the output is `Bonjour, Pierre` | ||
| - The `goodbyeMessage` field in the output is `Au revoir, Pierre` | ||
|
Comment on lines
-110
to
+112
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the variable is named |
||
| 3. Save your changes | ||
| 4. Run `mvn test`. This will fail, due to a bug in the Workflow Definition. | ||
| 5. Find and fix the bug in the Workflow Definition | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.