Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set lower value for clipping in SamplingProbablityCorrection #567

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aismlv
Copy link

@aismlv aismlv commented Oct 19, 2022

The current value of 1e-6 could be too high for larger datasets and could lead to model performance degradation. The original value was set here.

This PR sets the value to a lower 1.1920928955078125e-09 that comes from np.finfo(np.float32).eps / 100 in line with other clipping constants in the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant