Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redpanda tests #36

Merged

Conversation

HeyNonster
Copy link
Contributor

It seems1 that redpanda will now throw errors if the advertised address is set to 0.0.0.0.

Footnotes

  1. (https://github.com/redpanda-data/redpanda/issues/12395)

It seems[^1] that `redpanda` will now throw errors if the advertised
address is set to `0.0.0.0`.

[^1]: (redpanda-data/redpanda#12395)
@HeyNonster
Copy link
Contributor Author

Most tests run (and pass now) but still one error to figure out.

@guilleiguaran guilleiguaran self-requested a review February 6, 2024 07:49
redpanda/lib/testcontainers/redpanda.rb Outdated Show resolved Hide resolved
redpanda/lib/testcontainers/redpanda.rb Outdated Show resolved Hide resolved
@eddumelendez
Copy link
Member

Tests are green now! 🥳

@guilleiguaran guilleiguaran marked this pull request as ready for review February 8, 2024 16:16
@HeyNonster
Copy link
Contributor Author

Tests are green now! 🥳

Awesome work!!

@guilleiguaran guilleiguaran merged commit c2d98de into testcontainers:main Feb 8, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants