Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redpanda tests #36

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Fix redpanda tests #36

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60dc71f
Fix redpanda tests
HeyNonster Feb 2, 2024
609859d
Apply suggestions from code review
eddumelendez Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions redpanda/lib/testcontainers/redpanda.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ def _startup_script
startup_script = StringIO.new
startup_script.print("#!/bin/sh\n")
startup_script.print("/usr/bin/rpk redpanda start --mode dev-container")
eddumelendez marked this conversation as resolved.
Show resolved Hide resolved
startup_script.print(" --kafka-addr PLAINTEXT://0.0.0.0:29092,OUTSIDE://0.0.0.0:9092")
startup_script.print(" --advertise-kafka-addr PLAINTEXT://0.0.0.0:29092,OUTSIDE://#{host}:#{mapped_port(port)}")
startup_script.print(" --kafka-addr PLAINTEXT://127.0.0.1:29092,OUTSIDE://127.0.0.1:9092")
eddumelendez marked this conversation as resolved.
Show resolved Hide resolved
startup_script.print(" --advertise-kafka-addr PLAINTEXT://127.0.0.1:29092,OUTSIDE://#{host}:#{mapped_port(port)}")
startup_script
end

Expand Down
Loading