Added base intake class #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outsidermm
reviewed
Jan 11, 2024
components/intake.py
Outdated
|
|
||
|
|
||
| class Intake: | ||
| shooter_motor: wpilib.Talon |
There was a problem hiding this comment.
best not to assume hardware for a skeleton
components/intake.py
Outdated
| def deploy(self): | ||
| self.deployed = True | ||
|
|
||
| def is_ready(self): |
There was a problem hiding this comment.
add magicbot feedback decorator
There was a problem hiding this comment.
I think, generally for intake there can be three feedback methods
- is_note_present
- is_fully_retracted
- is_fully_deployed
components/intake.py
Outdated
|
|
||
|
|
||
| class Intake: | ||
| shooter_motor: wpilib.Talon |
There was a problem hiding this comment.
plz rename adequately for your variables intake isn't shooting...
There was a problem hiding this comment.
agreed, this one should be simply named motor; you already know this is the intake
|
#17 I think this can help |
|
Duplicate of #17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scaffold intake class for this season