Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small vision code cleanups/performance improvements #186

Merged
merged 2 commits into from
May 27, 2024
Merged

Small vision code cleanups/performance improvements #186

merged 2 commits into from
May 27, 2024

Conversation

auscompgeek
Copy link
Member

  • wpimath.objectToRobotPose was introduced last year.
  • The Pose2d constructor takes a Rotation2d in its 3-arg overload; we don't need to convert it to radians.

mlists
mlists approved these changes Mar 10, 2024
View reviewed changes
Copy link
Contributor

@mlists mlists left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auscompgeek auscompgeek force-pushed the vision-cleanup branch 2 times, most recently from 8188d51 to 4b7fcb2 Compare March 16, 2024 23:52
@auscompgeek auscompgeek force-pushed the vision-cleanup branch 2 times, most recently from d5f887a to fa648b2 Compare May 19, 2024 05:57
@auscompgeek auscompgeek merged commit 52170a1 into main May 27, 2024
6 checks passed
@auscompgeek auscompgeek deleted the vision-cleanup branch May 27, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlists mlists mlists approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@auscompgeek @mlists