Compute transform of hnf_with_transform after the fact
#1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1108 +/- ##
==========================================
+ Coverage 69.33% 69.49% +0.16%
==========================================
Files 349 349
Lines 112925 112967 +42
==========================================
+ Hits 78298 78509 +211
+ Misses 34627 34458 -169
☔ View full report in Codecov by Sentry. |
mgkurtz
force-pushed
the
mgk/hnf-via-saturate
branch
from
7566819 to
8b9ca36
Compare
mgkurtz
force-pushed
the
mgk/hnf-via-saturate
branch
from
8b9ca36 to
412a612
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my experience in #1102, it seemed to be worth wile, to compute the
SinH = ASby computing the hnfHand then solvingH = AS. At least for random square matrices this is much faster, than takingH, T = hnf_with_transform(A)and invertingT.Additionally, for random square matrices larger than 100×100, it even becomes faster to compute
TviaS.