Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printing of SRow in compound structures #1350

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

lgoettgens
Copy link
Contributor

before:

julia> (sparse_row(QQ), sparse_row(QQ))
(Sparse row with positions Int64[] and values QQFieldElem[]
, Sparse row with positions Int64[] and values QQFieldElem[]
)

julia> [sparse_row(QQ), sparse_row(QQ)]
2-element Vector{SRow{QQFieldElem, Vector{QQFieldElem}}}:
 Sparse row with positions Int64[] and values QQFieldElem[]

 Sparse row with positions Int64[] and values QQFieldElem[]

after:

julia> (sparse_row(QQ), sparse_row(QQ))
(Sparse row with positions Int64[] and values QQFieldElem[], Sparse row with positions Int64[] and values QQFieldElem[])

julia> [sparse_row(QQ), sparse_row(QQ)]
2-element Vector{SRow{QQFieldElem, Vector{QQFieldElem}}}:
 Sparse row with positions Int64[] and values QQFieldElem[]
 Sparse row with positions Int64[] and values QQFieldElem[]

@lgoettgens
Copy link
Contributor Author

The test failure seems unrelated to the changes.

@thofma
Copy link
Owner

thofma commented Jan 16, 2024

@benlorenz We are doing

julia --color=yes -e 'using Pkg; Pkg.add([PackageSpec(name="GAP"), PackageSpec(name="Polymake")]);'

for these tests and the Project toml has:

Polymake = "0.10, 0.11"

Somehow it is pulling in the new normaliz_jll?

Edit: The error is here: https://github.com/thofma/Hecke.jl/actions/runs/7532119397/job/20502117792?pr=1350#step:7:129

@benlorenz
Copy link
Contributor

Polymake works with both the old and new flint (there are two sets of binaries that are compatible with the current Polymake.jl, one based on flint 2.9 and one with 3.0). (Luckily there were no changes needed in Polymake.jl and this way the transition should be easier)

The test code is mixing/stacking incompatible environments, Polymake is installed in the global environment and loaded from there but Hecke and the dependencies are loaded from the source tree (using --project=@.), this way there is no compat bound for the dependencies of polymake.
You need to add Polymake+GAP to the Hecke environment, or create a new environment, add Polymake + GAP and develop the Hecke folder. Then run the Hecke tests for that environment.

@thofma thofma merged commit 91d0c2d into thofma:master Jan 16, 2024
14 of 15 checks passed
@thofma
Copy link
Owner

thofma commented Jan 16, 2024

Thanks @benlorenz. That makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants