Skip to content

Add Base.conj for AbsSimpleNumFieldElem #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2024

cache the complex_conjugation

c1c70c4
Select commit
Loading
Failed to load commit list.
Merged

Add Base.conj for AbsSimpleNumFieldElem #1622

cache the complex_conjugation
c1c70c4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 22, 2024 in 0s

75.87% (+0.08%) compared to d9b7787

View this Pull Request on Codecov

75.87% (+0.08%) compared to d9b7787

Details

Codecov Report

Attention: Patch coverage is 76.47059% with 8 lines in your changes missing coverage. Please review.

Project coverage is 75.87%. Comparing base (d9b7787) to head (c1c70c4).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/NumField/NfAbs/Conjugates.jl 76.47% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1622      +/-   ##
==========================================
+ Coverage   75.78%   75.87%   +0.08%     
==========================================
  Files         361      361              
  Lines      113695   113693       -2     
==========================================
+ Hits        86164    86261      +97     
+ Misses      27531    27432      -99     
Files with missing lines Coverage Δ
src/NumField/NfAbs/Conjugates.jl 83.98% <76.47%> (+0.09%) ⬆️

... and 38 files with indirect coverage changes