fix: Use exporter metadata in remote evaluations #2983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2983 +/- ##
==========================================
+ Coverage 84.72% 84.80% +0.07%
==========================================
Files 113 113
Lines 5239 5246 +7
==========================================
+ Hits 4439 4449 +10
+ Misses 634 632 -2
+ Partials 166 165 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
thomaspoignant
force-pushed
the
exporter-metadata-context
branch
from
c62c501 to
b84fb73
Compare
|
This was referenced Jan 24, 2025
thomaspoignant
added a commit
to open-feature/ruby-sdk-contrib
that referenced
this pull request
Jan 25, 2025
## This PR In this PR we support `exporterMetadata` that will allow to add static information that will be added to your feature event sent to the GO Feature Flag exporter. In this PR we add those exporter metadata to the evaluation context in order to pass them to GO Feature Flag relay-proxy. ### Related Issues thomaspoignant/go-feature-flag#2983 --------- Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For server providers it is not enough to manage exporter metadata in the collector API since some evaluation are directly done remotely and are generating evaluation data directly in the provider.
With this PR we allow the possibility to add exporter metadata in the evaluation context and to use them inside the relay-proxy.
Checklist
README.mdand/website/docs)