Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read from redis only if blob size is below limit. #303

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

fische
Copy link
Contributor

@fische fische commented Apr 22, 2024

@Hamishpk realised we read from redis even for blobs whose size is above the maxSize, which should therefore not be found there. This will hopefully limit the number of calls and help with the load on redis.

@fische fische requested a review from Hamishpk April 22, 2024 13:17
@fische fische self-assigned this Apr 22, 2024
Copy link
Contributor

@Hamishpk Hamishpk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fische fische merged commit 2a4bb1f into thought-machine:master Apr 22, 2024
5 checks passed
@fische fische deleted the redis-less-read branch April 22, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants