ci: update ci and add xtask testing

[gabriele-0201]

No description provided.

[gabriele-0201]

Current dependencies on/for this PR:

• main
  • PR xtask: require all binaries to be in the path #243
    • PR ci: update ci and add xtask testing #233 👈
      • PR xtask: add test local flag #244

This stack of pull requests is managed by Graphite.

[pepyakin]

At this point we could also extract this into an ARG.

[gabriele-0201]

I discovered that using ARG is more complex than expected. Doing something like this:

ARG POLKADOT=parity/polkadot:v1.6.0
FROM $POLKADOT as polkadot
COPY --from=polkadot /usr/bin/polkadot /usr/bin/

does not work because ARG can be defined at build time with an argument variable, and parity/polkadot:v1.6.0 would be used only if it is not specified. However, if it is specified but not assigned to anything, it would be empty, which is not valid for the FROM command. To make it work, it should be:

ARG POLKADOT=parity/polkadot:v1.6.0
FROM ${POLKADOT:-parity/polkadot:v1.6.0} as polkadot
COPY --from=polkadot /usr/bin/polkadot /usr/bin/

But if the goal is to reduce the lines that need to be changed on a Polkadot update, I opted for:

FROM parity/polkadot:v1.6.0 as polkadot
COPY --from=polkadot /usr/bin/polkadot /usr/bin/

[pepyakin]

Seems finicky: seems like you are assuming that project_dir will always come with a trailing slash, will that always be the case? Won't it be better to use Path? As a bonus you will be able to check the directory existence.

[gabriele-0201]

In the way I created the regex, it will contain the \, but you pointed out something really interesting. By using Path, the code becomes much cleaner and less errors prone

        let path = std::path::Path::new(project_dir).join("demo/sovereign/constants.json");
        if !path.exists() {
            bail!(
                "The `constants.json` file for Sovereign does not exist,\n \
                   or it is not in the expected position, `demo/sovereign/constants.json`"
            )
        }
        std::env::set_var("CONSTANTS_MANIFEST", path);