xtask: remove node binary from path #234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
gabriele-0201
force-pushed
the
gab_remove_node_in_path_requirement
branch
3 times, most recently
from
95b05a3 to
03fead3
Compare
gabriele-0201
force-pushed
the
gab_remove_node_in_path_requirement
branch
from
03fead3 to
7bdb25b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zombienet requires the node binary to be in the path.
Until now, it was sourced before calling 'zombienet.sh',
which made things more complex in CI.
Removing the need to source it before and instead
doing it in the test script makes it easier to work with
Implementing this, I understood better how Duct works, and I had to also change how I was executing the shim. Solving #232 it is probable that the way commands are executed will change again