Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kusama runtime: update ss58 #80

Merged
merged 1 commit into from
Dec 1, 2023
Merged

kusama runtime: update ss58 #80

merged 1 commit into from
Dec 1, 2023

Conversation

rphmeier
Copy link
Contributor

No description provided.

@rphmeier rphmeier mentioned this pull request Nov 30, 2023
Merged
@rphmeier Graphite App
Copy link
Contributor Author

rphmeier commented Nov 30, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@rphmeier rphmeier mentioned this pull request Nov 30, 2023
Merged
@rphmeier rphmeier force-pushed the rh11-29-rob-kusama-runtime branch from ea4d76d to 15462a1 Compare November 30, 2023 21:16
@rphmeier rphmeier force-pushed the rh-kusama-update-ss58 branch from ddff0d4 to f6faf38 Compare November 30, 2023 21:16
@rphmeier rphmeier mentioned this pull request Dec 1, 2023
Merged
pepyakin
pepyakin approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@pepyakin pepyakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

But honestly, I don't think there is any reason to add another dependency. This is only one goddamn number, which is a stable constant. If anything I would prefer it not to change. A magic number (supplied with a comment) would work marginally better.

@pepyakin pepyakin force-pushed the rh11-29-rob-kusama-runtime branch from 15462a1 to a9574a5 Compare December 1, 2023 15:11
@pepyakin pepyakin force-pushed the rh-kusama-update-ss58 branch from f6faf38 to fbe39cb Compare December 1, 2023 15:11
@rphmeier Graphite App
Copy link
Contributor Author

rphmeier commented Dec 1, 2023

I have been trying for 5 minutes to get Graphite to push this change and gave up. Will just merge as-is.

@rphmeier Graphite App
Copy link
Contributor Author

rphmeier commented Dec 1, 2023 •
edited
Loading

Merge activity

  • Dec 1, 1:45 PM: @rphmeier started a stack merge that includes this pull request via Graphite.
  • Dec 1, 1:46 PM: Graphite rebased this pull request as part of a merge.
  • Dec 1, 1:47 PM: @rphmeier merged this pull request with Graphite.

Base automatically changed from rh11-29-rob-kusama-runtime to main December 1, 2023 18:46
@rphmeier rphmeier force-pushed the rh-kusama-update-ss58 branch from fbe39cb to a2decdf Compare December 1, 2023 18:46
@rphmeier rphmeier merged commit 9c764b3 into main Dec 1, 2023
@rphmeier rphmeier deleted the rh-kusama-update-ss58 branch December 1, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepyakin pepyakin pepyakin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rphmeier @pepyakin