node: pull types from primitives #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 30, 2023
Merged
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
rphmeier
force-pushed
the
rh-kusama-update-ss58
branch
from
ddff0d4 to
f6faf38
Compare
rphmeier
force-pushed
the
rh_node_pull_types_from_primitives
branch
from
77c24bf to
8261811
Compare
pepyakin
approved these changes
Dec 1, 2023
pepyakin
reviewed
Dec 1, 2023
| #[cfg(test)] | ||
| mod tests { | ||
| // compile-test: ensure that the balance type used by Kusama matches the one used here. | ||
| fn balance_type_matches() { |
There was a problem hiding this comment.
I think this is missing #[test]
pepyakin
force-pushed
the
rh-kusama-update-ss58
branch
from
f6faf38 to
fbe39cb
Compare
pepyakin
force-pushed
the
rh_node_pull_types_from_primitives
branch
from
8261811 to
31ad7be
Compare
rphmeier
force-pushed
the
rh-kusama-update-ss58
branch
from
fbe39cb to
a2decdf
Compare
rphmeier
force-pushed
the
rh_node_pull_types_from_primitives
branch
from
31ad7be to
c21b0d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.