feat(torture): integrate with trickfs #768
Open
+171
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 30, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
pepyakin
force-pushed
the
pep-trickfs-enospc
branch
from
c2c202e to
a24b4ad
Compare
pepyakin
force-pushed
the
pep-trickfs-integration
branch
2 times, most recently
from
925d443 to
a387571
Compare
pepyakin
force-pushed
the
pep-trickfs-enospc
branch
from
a24b4ad to
2d5ddcf
Compare
| @@ -393,6 +438,25 @@ impl Workload { | |||
| return Err(anyhow::anyhow!("Commit did not execute successfully")); | |||
| }; | |||
|
|
|||
| if self.enabled_enospc { | |||
| // TODO: the same handling should be extended to the rollback. | |||
There was a problem hiding this comment.
The code should be very similar, so I think this TODO shooul be resolved in this pr before it is merged. Otherwise, we would have a broken torture because rollbacks could fail while torture expects them to succeed.
There was a problem hiding this comment.
I kindly disagree:
- trickfs is hidden behind a flag. The behavior is unchanged if the flag is off.
- I wish it was easy. I think I shared it with you before, that I would like to unify crashing and not crashing exercise paths. Non-crashing path is very similiar to the crashing one except it just does not crash. Now we have this multiplicity due to the enospc!
pepyakin
force-pushed
the
pep-trickfs-enospc
branch
from
2d5ddcf to
f463f70
Compare
pepyakin
force-pushed
the
pep-trickfs-integration
branch
from
a387571 to
ece9478
Compare
and as the first thing to test, just toggle on the ENOSPC from run to run.
pepyakin
force-pushed
the
pep-trickfs-integration
branch
from
ece9478 to
184fd76
Compare
pepyakin
force-pushed
the
pep-trickfs-enospc
branch
from
f463f70 to
041938b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and as the first thing to test, just toggle on the ENOSPC
from run to run.