Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: increment ID only append succeeded #771

Merged
merged 1 commit into from
Feb 4, 2025
Merged

fix: increment ID only append succeeded #771

merged 1 commit into from
Feb 4, 2025

Conversation

pepyakin
Copy link
Contributor

@pepyakin pepyakin commented Jan 30, 2025 •
edited
Loading

Otherwise it leads to gaps in IDs and the rollback log is rather
sensitive to those when it comes to recovery.

Fixes:

Error: Error during scanning segment /tmp/torture-CttwEt-workload-0/nomt_db/rollback.0000000001.log

Caused by:
    IDs are not ordered: this 10, expected 3

This was referenced Jan 30, 2025
Merged
Merged
Merged
Merged
Merged
@pepyakin Graphite App
Copy link
Contributor Author

pepyakin commented Jan 30, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pepyakin pepyakin mentioned this pull request Jan 30, 2025
Merged
@pepyakin pepyakin marked this pull request as ready for review January 30, 2025 19:10
gabriele-0201
gabriele-0201 approved these changes Jan 31, 2025
View reviewed changes
nomt/src/seglog/mod.rs Outdated Show resolved Hide resolved
@pepyakin pepyakin force-pushed the pep-trickfs-integration branch from a387571 to ece9478 Compare January 31, 2025 14:38
@pepyakin pepyakin force-pushed the pep-fix-seglog branch 2 times, most recently from 6712066 to 2a19cb3 Compare January 31, 2025 18:58
@pepyakin pepyakin force-pushed the pep-trickfs-integration branch 2 times, most recently from 184fd76 to c3d28ba Compare February 3, 2025 11:12
@pepyakin pepyakin force-pushed the pep-trickfs-integration branch from c3d28ba to 03838c0 Compare February 3, 2025 15:58
@pepyakin pepyakin mentioned this pull request Feb 3, 2025
Merged
@gabriele-0201 gabriele-0201 force-pushed the pep-trickfs-integration branch from 03838c0 to 435906a Compare February 4, 2025 15:33
Base automatically changed from pep-trickfs-integration to master February 4, 2025 16:46
@pepyakin
fix: increment ID only append succeeded
1256f61 
Otherwise it leads to gaps in IDs and the rollback log is rather
sensitive to those when it comes to recovery.
@pepyakin Graphite App
Copy link
Contributor Author

pepyakin commented Feb 4, 2025 •
edited
Loading

Merge activity

  • Feb 4, 2:14 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Feb 4, 2:14 PM EST: A user merged this pull request with Graphite.

@pepyakin pepyakin merged commit 1a8284f into master Feb 4, 2025
8 checks passed
@pepyakin pepyakin deleted the pep-fix-seglog branch February 4, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriele-0201 gabriele-0201 gabriele-0201 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pepyakin @gabriele-0201