Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(torture): handle poisoning #778

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

pepyakin
Copy link
Contributor

@pepyakin pepyakin commented Feb 3, 2025

when the database gets ENOSPC it becomes poisoned and it is required to
recreate it in order to perform further changes to the database.

this commit does that.

To get there, it was necessary to split initing of the agent (happens at
most once per agent process) from opening a NOMT instance (can happen
multiple times). Note that opening carries the fields such as
bitbox_seed and rollback which might not be useful each time. This
is by design, because we might want to test what happens if you do
change it from open to open.

@pepyakin pepyakin marked this pull request as ready for review February 3, 2025 15:59
@pepyakin pepyakin force-pushed the pep-fix-torture-handle-poison branch from 7dd3c6d to b450291 Compare February 4, 2025 17:04
Copy link
Contributor Author

pepyakin commented Feb 4, 2025

Merge activity

  • Feb 4, 2:14 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Feb 4, 2:15 PM EST: Graphite rebased this pull request as part of a merge.
  • Feb 4, 2:17 PM EST: A user merged this pull request with Graphite.

@pepyakin pepyakin changed the base branch from pep-fix-seglog to graphite-base/778 February 4, 2025 19:14
@pepyakin pepyakin changed the base branch from graphite-base/778 to master February 4, 2025 19:14
when the database gets ENOSPC it becomes poisoned and it is required to
recreate it in order to perform further changes to the database.

this commit does that.

To get there, it was necessary to split initing of the agent (happens at
most once per agent process) from opening a NOMT instance (can happen
multiple times). Note that opening carries the fields such as
`bitbox_seed` and `rollback` which might not be useful each time. This
is by design, because we might want to test what happens if you do
change it from open to open.
@pepyakin pepyakin force-pushed the pep-fix-torture-handle-poison branch from b450291 to 75dd790 Compare February 4, 2025 19:15
@pepyakin pepyakin merged commit 5e377a3 into master Feb 4, 2025
8 checks passed
@pepyakin pepyakin deleted the pep-fix-torture-handle-poison branch February 4, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants