Skip to content

open devtools link within atom#80

Open
twynsicle wants to merge 3 commits intotidev:masterfrom
twynsicle:master
Open

open devtools link within atom#80
twynsicle wants to merge 3 commits intotidev:masterfrom
twynsicle:master

Conversation

@twynsicle
Copy link

Scans console logs looking for the link to debug in dev-tools and opens the dev-tools automatically within atom, as per the following screenshot.

image

There are two features missing from this pull request as I wasn't sure how to incorporate them into the existing UI.
a) A way to add the --debug-host adb:55283 flag to the build - currently this will only work using the custom args run option.

I've been experimenting with the following, but it lacks a way to customize the port number.
image

b) A way to disable this feature if the user would rather open the dev-tools in Chrome. Currently there is no configuration menu to hook into
image

@chrisbowley
Copy link
Contributor

Awesome, thanks for the PR! I will take a look through. One thing, you might be able to remove the keymaps by adding the ‘native-key-bindings’ class to the browser.

@hansemannn
Copy link
Contributor

@twynsicle Thank you, this is huge! Wondering if we are (technically) able to do the same for iOS / Safari debugger?

@developer82
Copy link
Contributor

This seems like an awesome feature. Why was it not implemented?

@ewanharris
Copy link
Member

@developer82 There's a few things that made me put this on the backburner when I took a first look.

  • As we're just using the devtools, the debugger experience here would suffer from the same flaws as in normal Chrome today. We've made some improvements here recently (see fix: improve debugging of applications in third party tools and Studio alloy#893 and source mapping tweaks node-titanium-sdk#106). But I imagine even with those changes debugging an Alloy app wouldn't the same kind of experience as Studio which is ultimately what we'd want to achieve.
  • The debugging experience is effectively "out of source". While there is technically more integration, imo this isn't really much different to just opening the devtools link manually in Chrome
  • When we're adding features, we'd aim to support the majority of platforms initially. As we're using Chrome devtools here supporting iOS has some complications, we do have experience in solving these due to recent work done in Studio and VS Code, but it's not an insignificant amount of work to achieve it.

@developer82
Copy link
Contributor

Thanks. Is there a plan to allow debugging in Atom?

@ewanharris ewanharris force-pushed the master branch 2 times, most recently from d64dcb2 to c0965b5 Compare July 15, 2019 14:08
@ewanharris
Copy link
Member

@developer82, I can't make any guarantees. We will probably plan to investigate it, but unlike VS Code where debugging is a first class citizen of the editor, we may not be able to fully achieve the experience that we wish to provide.

@m1ga m1ga mentioned this pull request Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants