Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common_sensor_launch): remove duplicate code #336

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

zusizusi
Copy link
Contributor

@zusizusi zusizusi commented Oct 28, 2024

remove duplicate code in nebula_node_container.launch.py

slack

Signed-off-by: Sho Iwasawa <sho.iwasawa.2@tier4.jp>
@Ericpotato
Copy link
Contributor

@zusizusi
There is a conflict I guess? Can you solve it

@zusizusi
Copy link
Contributor Author

@Ericpotato
Thank you.🙏
I solved it.

Copy link
Contributor

@Ericpotato Ericpotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ericpotato Ericpotato merged commit cd07852 into tier4/universe Oct 31, 2024
8 of 10 checks passed
@Ericpotato Ericpotato deleted the tmp/v0.47/fix_hw_monitor branch October 31, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants