Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(srr520): initial driver #124

Merged
merged 51 commits into from
Jun 13, 2024
Merged

feat(srr520): initial driver #124

merged 51 commits into from
Jun 13, 2024

Conversation

knzo25
Copy link
Collaborator

@knzo25 knzo25 commented Mar 5, 2024

PR Type

  • New Feature

Related Links

Description

Initial hardware interface, decoder, and ros wrappers for the continental SRR520

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@knzo25 knzo25 requested review from mojomex and drwnz March 5, 2024 05:45
@knzo25 knzo25 self-assigned this Mar 5, 2024
@knzo25
Copy link
Collaborator Author

knzo25 commented Mar 5, 2024

@mojomex
Although it is marked for review, we still need to merge the ARS548 PR before addressing this one (also, the priority for this one is quite low)

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 20.13559% with 1178 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@44dea6f). Learn more about missing BASE report.

Files Patch % Lines
...ontinental/decoders/continental_srr520_decoder.cpp 43.82% 135 Missing and 188 partials ⚠️
...continental/continental_srr520_decoder_wrapper.cpp 0.00% 313 Missing ⚠️
..._hw_interfaces/continental_srr520_hw_interface.cpp 0.00% 202 Missing ⚠️
...src/continental/continental_srr520_ros_wrapper.cpp 0.00% 101 Missing ⚠️
...ontinental/continental_ros_decoder_test_srr520.cpp 29.41% 3 Missing and 81 partials ⚠️
...nental/continental_srr520_hw_interface_wrapper.cpp 0.00% 82 Missing ⚠️
...src/continental/continental_ars548_ros_wrapper.cpp 0.00% 33 Missing ⚠️
...ontinental/continental_ros_decoder_test_ars548.cpp 0.00% 0 Missing and 17 partials ⚠️
...ental/continental_ros_decoder_test_main_srr520.cpp 36.84% 1 Missing and 11 partials ⚠️
nebula_tests/continental/parameter_descriptors.cpp 12.50% 6 Missing and 1 partial ⚠️
... and 3 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #124   +/-   ##
==========================================
  Coverage           ?   15.11%           
==========================================
  Files              ?       93           
  Lines              ?     8888           
  Branches           ?     1549           
==========================================
  Hits               ?     1343           
  Misses             ?     6453           
  Partials           ?     1092           
Flag Coverage Δ
differential 15.11% <20.13%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drwnz drwnz requested a review from amc-nu March 6, 2024 06:25
@mojomex mojomex mentioned this pull request Mar 15, 2024
5 tasks
build_depends.repos Outdated Show resolved Hide resolved
@knzo25
Copy link
Collaborator Author

knzo25 commented May 22, 2024

This PR should be reviewed after #151 is merged

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
…this. need to test with actual hardware

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@knzo25 knzo25 changed the base branch from main to develop May 27, 2024 06:48
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
…iles

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
…c driver functionalities with a live sensor

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
…the config file

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Copy link
Collaborator

@mojomex mojomex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the feedback left above, everything looks good to me!

knzo25 and others added 7 commits June 13, 2024 17:24
Co-authored-by: Max Schmeller <6088931+mojomex@users.noreply.github.com>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@knzo25 knzo25 requested a review from mojomex June 13, 2024 10:54
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Copy link
Collaborator

@mojomex mojomex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@knzo25 knzo25 merged commit 204eb45 into tier4:develop Jun 13, 2024
9 checks passed
@mojomex mojomex mentioned this pull request Jul 18, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants