Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hesai): correct DUAL_STRONGEST_SECONDSTRONGEST return mode enum value #192

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

msz-rai
Copy link
Contributor

@msz-rai msz-rai commented Sep 4, 2024

PR Type

  • Bug Fix

Related Links

Hesai user manuals: link

Description

In the Hesai QT128C2X user manual, the Strongest, Second Strongest return mode flag is defined as 0x3E. This PR corrects the enum value based on the manual's specification.

image

Review Procedure

Double-check with the manual.

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex self-requested a review September 5, 2024 05:03
@mojomex mojomex changed the title Fix DUAL_STRONGEST_SECONDSTRONGEST return mode flag value fix(hesai): correct DUAL_STRONGEST_SECONDSTRONGEST return mode enum value Sep 5, 2024
Copy link
Collaborator

@mojomex mojomex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR, @msz-rai!
I appreciate you taking the time to describe even a small change in detail 😃

LGTM 🚀

@mojomex mojomex merged commit 01781a6 into tier4:main Sep 5, 2024
6 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants