Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use base_link for default imu frame_id #1388

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Use base_link for default imu frame_id #1388

merged 3 commits into from
Sep 24, 2024

Conversation

HansRobo
Copy link
Collaborator

@HansRobo HansRobo commented Sep 18, 2024

Description

Abstract

Fix frame_id of imu

before: tamagawa/imu_link
after: base_link

Background

Due to misunderstandings, the wrong frame_id was introduced.

Details

The imu_corrector transforms the imu original frame to the base_link.
https://github.com/autowarefoundation/autoware.universe/blob/main/sensing/autoware_imu_corrector/src/imu_corrector_core.cpp#L104

References

regression test: OK

Destructive Changes

This is a destructive changes but a simple positive improvement.

Known Limitations

None

Copy link

github-actions bot commented Sep 18, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@HansRobo HansRobo added wait for regression test bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 labels Sep 18, 2024
@HansRobo HansRobo marked this pull request as ready for review September 24, 2024 07:21
@HansRobo HansRobo merged commit 97995ea into master Sep 24, 2024
10 checks passed
@HansRobo HansRobo deleted the fix/imu_frame branch September 24, 2024 09:11
@github-actions github-actions bot restored the fix/imu_frame branch September 24, 2024 09:12
@github-actions github-actions bot deleted the fix/imu_frame branch September 24, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 wait for regression test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants