Skip to content

use 'export X from Y' syntax#50

Open
liady wants to merge 1 commit intotimqian:masterfrom
liady:patch-1
Open

use 'export X from Y' syntax#50
liady wants to merge 1 commit intotimqian:masterfrom
liady:patch-1

Conversation

@liady
Copy link
Copy Markdown

@liady liady commented Oct 31, 2019

Related issue

Fix #issueNumber

Screenshot before and after this change

import Radar from './Radar';
import config from './config';

module.exports = {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liady I think, this would pose the inconsistency in the codebase, most of the files have exports at end file.
@timqian Any thoughts?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, consistency is important. And personally I prefer doing exports at the end of a file because it is easier to tell what a file is exporting (by looking at the bottom)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants