Skip to content

use 'export X from Y' syntax #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liady wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use 'export X from Y' syntax #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
import Bar from './Bar';
import Pie from './Pie';
import Line from './Line';
import XY from './XY';
import Radar from './Radar';
import config from './config';

module.exports = {
Copy link
Copy Markdown
Contributor

@ajduke ajduke Nov 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liady I think, this would pose the inconsistency in the codebase, most of the files have exports at end file.
@timqian Any thoughts?

Copy link
Copy Markdown
Owner

@timqian timqian Nov 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, consistency is important. And personally I prefer doing exports at the end of a file because it is easier to tell what a file is exporting (by looking at the bottom)

config, Bar, Pie, Line, XY, Radar,
};
export Bar from './Bar';
export Pie from './Pie';
export Line from './Line';
export XY from './XY';
export Radar from './Radar';
export config from './config';