Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HermeticFetchContent v1.0.6 : CUSTOM_INSTALL_TARGETS new parameter + HermeticFetchContent v1.0.7 : GIT_SUBMOULES FetchContent parameter #8

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

daminetreg
Copy link
Contributor

@daminetreg daminetreg commented Jan 28, 2025

HermeticFetchContent v1.0.6 : CUSTOM_INSTALL_TARGETS new parameter
For projects where the install target doesn't work it's possible to use
projects that don't provide an install target or that don't install the
files needed for the library to be consumed.

To support these projects new placeholders to access the dependency
build tree were added.

CHANGELOG

  • CUSTOM_INSTALL_TARGETS parameter are run as cmake --build --target <>
    instead of the --install when provided
  • HERMETIC_CMAKE_EXPORT_LIBRARY_DECLARATION supports 2 new
    placeholders to support declaring targets :
    • @HFC_SOURCE_DIR_PLACEHOLDER@
    • @HFC_BINARY_DIR_PLACEHOLDER@

Change-Id: Ib69ece818b6752cdac3ebe18d12101f60d4e6030


HermeticFetchContent v1.0.7 : GIT_SUBMOULES FetchContent parameter
In HermeticFetchContent some parameters from FetchContent are gated to
support the source caching feature. This adds the GIT_SUBMODULE parameter
in order to select the submodules to clone.

CHANGELOG

  • GIT_SUBMOULES FetchContent parameter supported in HermeticFetchContent

Change-Id: Iede352d7f130f920face250a083dc029e3f0db06

@daminetreg daminetreg requested a review from pysco68 January 28, 2025 09:00
@daminetreg daminetreg force-pushed the feature/hfc-recursive branch from 7a8d305 to 4879e14 Compare January 28, 2025 09:25
@daminetreg daminetreg force-pushed the feature/hfc-recursive-custom-install-targets branch from 36d7676 to 640b264 Compare January 28, 2025 09:44
@daminetreg daminetreg changed the base branch from feature/hfc-recursive to main January 28, 2025 09:49
For projects where the install target doesn't work it's possible to use
projects that don't provide an install target or that don't install the
files needed for the library to be consumed.

To support these projects new placeholders to access the dependency
build tree were added.

CHANGELOG

- CUSTOM_INSTALL_TARGETS parameter are run as `cmake --build --target <>`
  instead of the --install when provided
- HERMETIC_CMAKE_EXPORT_LIBRARY_DECLARATION supports 2 new
  placeholders to support declaring targets :
  - @HFC_SOURCE_DIR_PLACEHOLDER@
  - @HFC_BINARY_DIR_PLACEHOLDER@

Change-Id: Ib69ece818b6752cdac3ebe18d12101f60d4e6030
In HermeticFetchContent some parameters from FetchContent are gated to
support the source caching feature. This adds the GIT_SUBMODULE parameter
in order to select the submodules to clone.

CHANGELOG

- GIT_SUBMOULES FetchContent parameter supported in HermeticFetchContent

Change-Id: Iede352d7f130f920face250a083dc029e3f0db06
@daminetreg daminetreg force-pushed the feature/hfc-recursive-custom-install-targets branch from 640b264 to 5e1df64 Compare January 28, 2025 10:01
@daminetreg daminetreg marked this pull request as ready for review January 28, 2025 10:04
@daminetreg daminetreg changed the title CUSTOM_INSTALL_TARGETS for projects where the install target doesn't work HermeticFetchContent v1.0.6 : CUSTOM_INSTALL_TARGETS new parameter + HermeticFetchContent v1.0.7 : GIT_SUBMOULES FetchContent parameter Jan 28, 2025
Copy link
Contributor

@Lambourl Lambourl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@pysco68 pysco68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM

@daminetreg daminetreg merged commit d96218a into main Jan 28, 2025
1 check passed
@daminetreg daminetreg deleted the feature/hfc-recursive-custom-install-targets branch February 4, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants