Skip to content

Refactor PropertyResolverGenerator to remove commented code and simplify logic; update tests for generated methods #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tombiddulph merged 1 commit into from
Feb 6, 2026
Merged

Refactor PropertyResolverGenerator to remove commented code and simplify logic; update tests for generated methods #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions src/PropertyResolvers.Generators/PropertyResolverGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,6 @@ public class PropertyResolverGenerator : IIncrementalGenerator
/// <inheritdoc />
public void Initialize(IncrementalGeneratorInitializationContext context)
{
// // Register the attribute source
// context.RegisterPostInitializationOutput(ctx => ctx.AddSource(
// "GeneratePropertyResolverAttribute.g.cs",
// SourceText.From(AttributeSourceCode, Encoding.UTF8)));

// Get configs and root namespace from compilation
var compilationData = context.CompilationProvider
.Select((compilation, _) => (
Expand Down Expand Up @@ -239,18 +234,12 @@ private static void GenerateResolvers(
.Select(p => (TypeFullName: t.FullName, PropertyName: p.Name, p.IsNullable)))
.ToList();

if (matches.Count == 0)
{
continue;
}

const string returnType = "string?";
var methodName = $"Get{config.PropertyName}";

methods.AppendLine($" public static {returnType} {methodName}(object? obj) => obj switch");
methods.AppendLine(" {");


foreach (var (typeName, propertyName, isNullable) in matches)
{
var toStringCall = isNullable ? "?.ToString()" : ".ToString()";
Expand Down
8 changes: 6 additions & 2 deletions tests/PropertyResolvers.Tests/PropertyResolverGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,8 @@ public class Order

var generatedCode = generatedFile.GetText().ToString();
Assert.Contains("public static class NonExistentPropertyResolver", generatedCode);
Assert.DoesNotContain("public static string?", generatedCode);
Assert.Contains("public static string? GetNonExistentProperty(object? obj)", generatedCode);
Assert.Contains("_ => null", generatedCode);
}

[Fact]
Expand Down Expand Up @@ -449,7 +450,10 @@ public class AnotherGeneric<TKey, TValue>

var generatedCode = generatedFile.GetText().ToString();
Assert.Contains("public static class AccountIdResolver", generatedCode);
Assert.DoesNotContain("public static string?", generatedCode);
Assert.Contains("public static string? GetAccountId(object? obj)", generatedCode);
Assert.Contains("_ => null", generatedCode);
// No type-specific match arms since all types are generic
Assert.DoesNotContain("global::TestNamespace", generatedCode);
}

[Fact]
Expand Down