feat: support securityContext and podSecurityContext configuration #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… helm chart Signed-off-by: wparr-circle <william.parr@circle.com>
ushitora-anqou
previously approved these changes
Jun 25, 2024
ushitora-anqou
dismissed
their stale review
I forgot to check that the CI passed.
ushitora-anqou
requested changes
Jun 25, 2024
There was a problem hiding this comment.
Could you please update the README using this guide? Thanks!
Signed-off-by: wparr-circle <william.parr@circle.com>
@ushitora-anqou my bad! I've pushed the updated readme in befc39d |
ushitora-anqou
approved these changes
Jun 26, 2024
pluser
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #264
Adds two new helm values controller.securityContext, and controller.podSecurityContext - these correspond to Container level Security Context and Pod level Security Context respectively.
This may be leveraged to setup a security context complaint with pod security standards etc.