Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 일관된 이름 짓기 규칙에 알맞게 함수명 수정 #191

Closed
wants to merge 2 commits into from
Closed

feat: 일관된 이름 짓기 규칙에 알맞게 함수명 수정 #191

wants to merge 2 commits into from

Conversation

Collection50
Copy link
Contributor

@Collection50 Collection50 commented Jul 15, 2024 •
edited
Loading

Overview

#170 을 해결했습니다.

PR Checklist

  • I read and included theses actions below

close #170

  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8a9aa39

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jul 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ❌ Failed (Inspect) Jul 20, 2024 7:43am

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.69%. Comparing base (b6cde8e) to head (8a9aa39).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
- Coverage   95.18%   94.69%   -0.49%     
==========================================
  Files          17       15       -2     
  Lines         291      283       -8     
  Branches       67       66       -1     
==========================================
- Hits          277      268       -9     
- Misses         13       14       +1     
  Partials        1        1

@Collection50
Copy link
Contributor Author

Collection50 commented Jul 20, 2024 •
edited
Loading

고민점은 아래와 같습니다 !

  1. amountToMoneyUnit에서 hangul을 제외하면 amountTo로 되어 어색한 점이 많다고 생각했습니다. 금액으로 반환하는 특성을 고려하여 네이밍했습니다 !!
  2. ./_internal/hangul의 폴더명은 hangul로 시작하고합니다. 내부에서도 isHangulCharacter, isHangulAlphabet등 hangul을 제외하면 기능이 무엇인지 유추되지 않을 것이라고 판단해 네이밍을 그대로 유지했습니다 !!

@okinawaa okinawaa mentioned this pull request Jul 21, 2024
Closed
okinawaa
okinawaa reviewed Jul 23, 2024
View reviewed changes
src/index.ts
export { extractHangul } from './extractHangul';
export { acronymizeHangul } from './acronymizeHangul';

const hangul = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이렇게 export default를 명시적으로 해주지 않아도,
모듈시스템의 도움을 받아서 지금 상태여도
hangul.josa 요런식으로 사용가능하지 않나요?

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정해두겠습니다 !!

@Collection50 Collection50 mentioned this pull request Jul 28, 2024
Merged
1 task
@okinawaa
Copy link
Member

okinawaa commented Aug 2, 2024 •
edited
Loading

#204 와 작업 범위가 같다면, 이 PR은 닫아도 될까요?

@Collection50
Copy link
Contributor Author

#204 와 작업 범위가 같다면, 이 PR은 닫아도 될까요?

넵 !

@okinawaa okinawaa closed this Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okinawaa okinawaa okinawaa left review comments

@raon0211 raon0211 Awaiting requested review from raon0211 raon0211 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: 정해진 일관된 이름 짓기 규칙에 알맞게 함수명 수정하기
3 participants
@Collection50 @codecov-commenter @okinawaa