fix: 일관된 한글 이름 규칙 설정 (to v2) #204

Collection50 · 2024-07-28T14:12:34Z

Overview

#191 에서 이야기를 나눈 것을 반영하여 merge 대상 브랜치를 main에서 v2로 변경합니다.

PR Checklist

I read and included theses actions below

I have read the Contributing Guide
I have written documents and tests, if needed.

* remove extrachHangul * Create cyan-tigers-sneeze.md --------- Co-authored-by: Jonghyeon Ko <manudeli.ko@gmail.com>

…angul이라는 글자를 제거합니다 (toss#184) * dissemble관련 메서드에서 hangul이름을 제거합니다 * 누락된 부분 수정 * resolve conflit * Create late-beers-hang.md * diassembleHangul to diassemble --------- Co-authored-by: Jonghyeon Ko <manudeli.ko@gmail.com>

* remove acronymize * Create weak-walls-sniff.md --------- Co-authored-by: Jonghyeon Ko <manudeli.ko@gmail.com>

* getChoseong분리 * write test code * getChoseong import * remove useless import statemenet * remove unused file

…도 함수로 분리합니다. (toss#193) * canBe series를 별도 함수로 분리합니다 * add change set

* hasBatchim * resolve type error * add change set * hasProperty, hasValueInReadOnlyStringList를 internal folder 로 옮깁니다 * resolve test error * move with test code

* remove choseongIncludes Co-authored-by: 서동휘 <8275026+suhdonghwi@users.noreply.github.com>

changeset-bot · 2024-07-28T14:12:37Z

🦋 Changeset detected

Latest commit: b231729

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2024-07-28T14:12:38Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
es-hangul	❌ Failed (Inspect)			Aug 5, 2024 5:05pm

codecov-commenter · 2024-07-28T14:14:42Z

Codecov Report

Attention: Patch coverage is 90.00000% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (v2@01843b8). Learn more about missing BASE report.

Additional details and impacted files

@@          Coverage Diff          @@
##             v2     #204   +/-   ##
=====================================
  Coverage      ?   96.83%           
=====================================
  Files         ?       30           
  Lines         ?      601           
  Branches      ?      148           
=====================================
  Hits          ?      582           
  Misses        ?       15           
  Partials      ?        4

okinawaa · 2024-07-30T02:36:26Z

amountToHangul의 함수명이 amountToMoneyUnit으로 바뀐 이유가 궁금합니다!
amountToHangul이 조금 더 직관적이라고 생각이 들어서요, moneyUnit은 금액 단위만 반환해주는것아닌가? 라는 오해가 있을 수 있을 것 같아요!

Collection50 · 2024-07-30T04:04:30Z

@okinawaa amountToHangulCurrency는 어떠신가요-??

한국 통화 느낌을 강조해보았습니다 !

amountToHangul이라는 것은 한글의 양 총합이라는 느낌으로 오해할 수 있을 같다고 생각해서 변경했었습니다 !

okinawaa · 2024-08-01T02:14:09Z

amountToHangulCurrency 좋습니다!

Collection50 · 2024-08-01T10:00:18Z

@okinawaa 수정 완료했니다 !

okinawaa · 2024-08-02T04:38:26Z

@manudeli 님!
amountToHangul을 amountToHangulCurrency로 변경하는것에 대해서 의견이 궁금한데 어떻게 생각하시나요?
"통화" 라는 맥락을 담는게 맞을지, 아니면 그냥 숫자를 한글로 변환만해주는다는 맥락만 담는게 좋을까요?

okinawaa · 2024-08-02T04:48:24Z

함수가 하는 역할은 숫자 => 한글인데, "돈" 이라는 money가 들어간 이유가 궁금해요!

okinawaa · 2024-08-02T04:49:21Z

우선 논의가 길어지는것 같아서 amountToHangul은 변경사항 이전으로 돌리고,
이 PR은 hangul을 없애는것만 반영하여 PR을 수정해주시는것은 어떨까요?
amountToHangul은 별도 이슈를 파서 논의하면 좋을 것 같아요!

manudeli · 2024-08-02T08:09:20Z

@manudeli 님! amountToHangul을 amountToHangulCurrency로 변경하는것에 대해서 의견이 궁금한데 어떻게 생각하시나요? "통화" 라는 맥락을 담는게 맞을지, 아니면 그냥 숫자를 한글로 변환만해주는다는 맥락만 담는게 좋을까요?

Currency이 함수명에 포함될 필요가 없어보여요. 반드시 화폐만을 위한 기능이 아니어보여서요. 대안은 고민해보고 있습니다

Collection50 · 2024-08-03T08:42:34Z

우선 논의가 길어지는것 같아서 amountToHangul은 변경사항 이전으로 돌리고,
이 PR은 hangul을 없애는것만 반영하여 PR을 수정해주시는것은 어떨까요?
amountToHangul은 별도 이슈를 파서 논의하면 좋을 것 같아요!

네 알겠습니다 !

okinawaa · 2024-08-04T08:57:41Z

@Collection50 님 v2로 나아가기 위해, 이 PR의 머지가 필요해서요! 컨플릭 해결작업 진행해주시면 감사하겠습니다! 🙇

Collection50 · 2024-08-04T14:57:43Z

@okinawaa 완료했습니다 !

okinawaa · 2024-08-05T03:51:14Z

CHANGELOG.md

-## 1.5.0
-
-### Minor Changes
-
- [#115](https://github.com/toss/es-hangul/pull/115) [`84584d4`](https://github.com/toss/es-hangul/commit/84584d48ac5ded83c55934f0b72e37a6b889f4e1) Thanks [@po4tion](https://github.com/po4tion)! - feat: 한국어를 로마자로 변환해주는 함수와 한국어를 표준 발음법으로 변환해주는 함수를 만들고 문서화를 진행합니다
-
-## 1.4.7
-
-### Patch Changes
-
- [#201](https://github.com/toss/es-hangul/pull/201) [`56db7f0`](https://github.com/toss/es-hangul/commit/56db7f0140ee369fbe0dc2dad834e8d6a218a4ea) Thanks [@BO-LIKE-CHICKEN](https://github.com/BO-LIKE-CHICKEN)! - feat: 숫자를 순 우리말 수사로 변환하거나 수 관형사로 변환하는 함수를 추가
-
-## 1.4.6
-
-### Patch Changes
-
- [#198](https://github.com/toss/es-hangul/pull/198) [`e6142b0`](https://github.com/toss/es-hangul/commit/e6142b04159133dbcab6f2771baa88adf7aa4a45) Thanks [@linenumbertwo](https://github.com/linenumbertwo)! - feat: "이라/라" 케이스 추가
-
- [#203](https://github.com/toss/es-hangul/pull/203) [`fbe3ad6`](https://github.com/toss/es-hangul/commit/fbe3ad67f4bd796773f60f0ab04359135b03d414) Thanks [@kangju2000](https://github.com/kangju2000)! - fix: eslint CI가 제대로 작동하지 않는 문제를 수정합니다.


이 체인지 로그는 삭제된 이유가 있을까요?!

잘못 삭제된 것으로 보입니다 ! 수정해두겠습니다 !

okinawaa · 2024-08-05T03:53:10Z

src/index.ts

+export {
+  assemble,
+  combineCharacter,
+  combineVowels,
+  curriedCombineCharacter,
+  convertQwertyToHangul,
+  convertQwertyToAlphabet,
+  disassemble,
+  disassembleToGroups,
+  disassembleCompleteCharacter,
+  josa,
+  removeLastCharacter,
+  hasBatchim,
+  canBeChoseong,
+  canBeJongseong,
+  canBeJungseong,
+  getChoseong,
+  amountToHangul,
+  romanize,
+  susa,
+  standardizePronunciation,
+};


export 구문으로 바로 import 후 export 를 시키고 있었는데,
이렇게 import / export 따로 진행하신 이유가 있나요?
두번씩 작성해야하는것에 대비하여 장점을 크게 못느껴서요!

수정해두겠습니다 !!

okinawaa · 2024-08-05T03:53:57Z

src/index.ts

-export { canBeChoseong, canBeJongseong, canBeJungseong } from './canBe';
-export { getChoseong } from './getChoseong';
+import { assemble } from './assemble';
+import { combineCharacter, combineVowels, curriedCombineCharacter } from './combineCharacter';


curriedCombineCharacter는 외부로 노출하지 않는것이 좋을 것 같아요
combineCharacter 로 충분히 구현가능하고 combineCharacter 함수가 매우 작은 단위이므로 요구사항을 충분히 사용하는쪽에서 구현가능하다고 생각해요!!

네 알겠습니다 !

okinawaa

너무 감사합니다!!

okinawaa and others added 10 commits July 14, 2024 16:25

feat: 문자열에서 한글을 추출해주는 extractHangul 함수를 제거합니다 (toss#185)

357ff9f

* remove extrachHangul * Create cyan-tigers-sneeze.md --------- Co-authored-by: Jonghyeon Ko <manudeli.ko@gmail.com>

remove hangulIncludes (toss#188)

84eead8

Merge branch 'main' into v2

6cf364d

feat: 한글의 두음을 반환해주는 acronymizeHangul 함수를 제거합니다. (toss#180)

fec20e8

* remove acronymize * Create weak-walls-sniff.md --------- Co-authored-by: Jonghyeon Ko <manudeli.ko@gmail.com>

feat: getChoseng을 utils에서 별도 함수로 분리합니다. (toss#192)

f115c54

* getChoseong분리 * write test code * getChoseong import * remove useless import statemenet * remove unused file

feat: canBeChoseong, canBeJungseong, canBeJongseong 을 utils에서 별…

0cfbed6

…도 함수로 분리합니다. (toss#193) * canBe series를 별도 함수로 분리합니다 * add change set

feat: hasBatchim 을 utils에서 별도 함수로 분리합니다. (toss#195)

aa7aae1

* hasBatchim * resolve type error * add change set * hasProperty, hasValueInReadOnlyStringList를 internal folder 로 옮깁니다 * resolve test error * move with test code

feat: choseongIncludes함수를 제거합니다. (toss#197)

f60b9d8

* remove choseongIncludes Co-authored-by: 서동휘 <8275026+suhdonghwi@users.noreply.github.com>

fix: remove 한글

7c72f1b

Collection50 requested review from okinawaa and raon0211 as code owners July 28, 2024 14:12

vercel bot had a problem deploying to Preview July 28, 2024 14:13 Failure

fix: amountToMoneyCurrency로 함수명 변경

3c44350

vercel bot had a problem deploying to Preview August 1, 2024 10:00 Failure

This was referenced Aug 2, 2024

feat: 일관된 이름 짓기 규칙에 알맞게 함수명 수정 #191

Closed

chore: amountToHangul 함수 export #211

Closed

[Bug]: amountToHangul 함수명이 괜찮은가요? #214

Open

fix: amountToHangul로 함수명 수정

4e2c14c

vercel bot had a problem deploying to Preview August 3, 2024 08:46 Failure

okinawaa force-pushed the v2 branch from 8f7b5f4 to 2022a0a Compare August 4, 2024 03:52

okinawaa force-pushed the v2 branch from fbffc18 to 01843b8 Compare August 4, 2024 11:12

fix: conflict 해결

fc68c87

vercel bot had a problem deploying to Preview August 4, 2024 14:49 Failure

fix: conflict

21684f6

vercel bot had a problem deploying to Preview August 4, 2024 14:51 Failure

fix: filepath

f85fd81

vercel bot had a problem deploying to Preview August 4, 2024 14:56 Failure

okinawaa reviewed Aug 5, 2024

View reviewed changes

fix: import 방식 변경 및 CHANGELOG restore

633cd20

vercel bot had a problem deploying to Preview August 5, 2024 06:30 Failure

Create kind-birds-provide.md

b231729

vercel bot had a problem deploying to Preview August 5, 2024 17:05 Failure

okinawaa approved these changes Aug 5, 2024

View reviewed changes

okinawaa merged commit 82e03c3 into toss:v2 Aug 5, 2024
9 of 10 checks passed

github-actions bot mentioned this pull request Aug 5, 2024

v2 #225

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: 일관된 한글 이름 규칙 설정 (to v2) #204

fix: 일관된 한글 이름 규칙 설정 (to v2) #204

Collection50 commented Jul 28, 2024

changeset-bot bot commented Jul 28, 2024 •

edited

Loading

vercel bot commented Jul 28, 2024 •

edited

Loading

codecov-commenter commented Jul 28, 2024 •

edited

Loading

okinawaa commented Jul 30, 2024

Collection50 commented Jul 30, 2024 •

edited

Loading

okinawaa commented Aug 1, 2024

Collection50 commented Aug 1, 2024

okinawaa commented Aug 2, 2024

okinawaa commented Aug 2, 2024

okinawaa commented Aug 2, 2024

manudeli commented Aug 2, 2024 •

edited

Loading

Collection50 commented Aug 3, 2024

okinawaa commented Aug 4, 2024

Collection50 commented Aug 4, 2024

okinawaa Aug 5, 2024

Collection50 Aug 5, 2024

okinawaa Aug 5, 2024

Collection50 Aug 5, 2024

okinawaa Aug 5, 2024

Collection50 Aug 5, 2024

okinawaa left a comment

fix: 일관된 한글 이름 규칙 설정 (to v2) #204

fix: 일관된 한글 이름 규칙 설정 (to v2) #204

Conversation

Collection50 commented Jul 28, 2024

Overview

PR Checklist

changeset-bot bot commented Jul 28, 2024 • edited Loading

🦋 Changeset detected

vercel bot commented Jul 28, 2024 • edited Loading

codecov-commenter commented Jul 28, 2024 • edited Loading

Codecov Report

okinawaa commented Jul 30, 2024

Collection50 commented Jul 30, 2024 • edited Loading

okinawaa commented Aug 1, 2024

Collection50 commented Aug 1, 2024

okinawaa commented Aug 2, 2024

okinawaa commented Aug 2, 2024

okinawaa commented Aug 2, 2024

manudeli commented Aug 2, 2024 • edited Loading

Collection50 commented Aug 3, 2024

okinawaa commented Aug 4, 2024

Collection50 commented Aug 4, 2024

okinawaa Aug 5, 2024

Choose a reason for hiding this comment

Collection50 Aug 5, 2024

Choose a reason for hiding this comment

okinawaa Aug 5, 2024

Choose a reason for hiding this comment

Collection50 Aug 5, 2024

Choose a reason for hiding this comment

okinawaa Aug 5, 2024

Choose a reason for hiding this comment

Collection50 Aug 5, 2024

Choose a reason for hiding this comment

okinawaa left a comment

Choose a reason for hiding this comment

changeset-bot bot commented Jul 28, 2024 •

edited

Loading

vercel bot commented Jul 28, 2024 •

edited

Loading

codecov-commenter commented Jul 28, 2024 •

edited

Loading

Collection50 commented Jul 30, 2024 •

edited

Loading

manudeli commented Aug 2, 2024 •

edited

Loading