Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove crash handler registration #1

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

jwelton
Copy link

@jwelton jwelton commented Apr 29, 2024

Context

Currently, the Rollbar public API doesn't support disabling registration of the crash handler. This pull request comments out where the SDK registers the crash handler, so we don't interfere with other tooling that uses this handler.

Checklist

Copy link

@tasos-tsolis tasos-tsolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we going to make sure that we are not going to forget in x months to check for the public API of the Rollbar SDK? Should we create a Jira ticket for reference?

@jwelton
Copy link
Author

jwelton commented Apr 29, 2024

How are we going to make sure that we are not going to forget in x months to check for the public API of the Rollbar SDK? Should we create a Jira ticket for reference?

Ticket created here: https://transferwise.atlassian.net/browse/AMO-126

@jwelton jwelton merged commit fa2572a into master Apr 29, 2024
1 check passed
@jwelton jwelton deleted the feature/remove-crash-handler branch April 29, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants