Add show_progress flag to BulkImportWriter
#141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidLandup0
requested review from
tung-vu-td and
chezou
and removed request for
tung-vu-td
DavidLandup0
commented
Dec 5, 2024
| @@ -1,10 +1,10 @@ | |||
| """IPython Magics | |||
|
|
|||
| IPython magics to access to Treasure Data. Load the magics first of all: | |||
| IPython magics to access to Treasure Data. Load the magics first of all: | |||
There was a problem hiding this comment.
Not sure why the linter decided to remove the tab here?
There was a problem hiding this comment.
I think the linter is correct though. Multiline comments usually align with the """, not the text
chezou
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
show_progressflag to theBulkImportWriter, to optionally show the progress of chunking intomsgpackformat and uploading the temp files. Defaults toFalseso backwards compatibility is preserved.Does not affect the progress of the
bulk_import.perform()orbulk_import.commit()calls.Not sure if this is even something we're looking to add so feel free to close if it's not meant to be supported (especially if we want to keep dependencies low) - I just found it personally to be a nice touch for developer experience when working with large DataFrame uploads :)